Show headers on macOS environment table; improve scrolling

Author: rakillen

webui/src/css/app.css

@@ -441,6 +441,7 @@ h6:first-child {
   overflow: auto;
 }
 
+.wkt-macos-env-variables-dialog,
 .wkt-macos-path-directories-dialog {
   width: 85%;
   height: 85vh;
@@ -479,6 +480,25 @@ h6:first-child {
   grid-column-end: 2;
 }
 
+/* some dialogs need 100% height / width body content */
+
+.wkt-fixed-body-dialog .oj-dialog-body,
+.wkt-fixed-body-dialog .oj-dialog-content,
+.wkt-fixed-body-dialog .oj-dialog-content > div {
+  width: 100%;
+  height: 100%;
+}
+
+.wkt-full-height {
+  height: 100%;
+  overflow: auto;
+}
+
+.wkt-macos-env-variables-dialog .oj-table {
+  width: 100%;
+  height: 100%;
+}
+
 /* the oj-switcher in the code view should use the remaining height */
 .wkt-code-view-switcher {
   min-height: 1px;

webui/src/js/views/macos-environment-variables-dialog.html

@@ -2,18 +2,19 @@
  Copyright (c) 2022, Oracle and/or its affiliates.
  Licensed under The Universal Permissive License (UPL), Version 1.0 as shown at https://oss.oracle.com/licenses/upl/
  -->
-<oj-dialog id="wktMacosEnvironmentVariablesDialog" class="wkt-macos-path-directories-dialog" initial-visibility="hide">
+<oj-dialog id="wktMacosEnvironmentVariablesDialog" class="wkt-macos-env-variables-dialog wkt-fixed-body-dialog" initial-visibility="hide">
   <div slot="header">
     <span class="oj-dialog-title"><oj-bind-text value="[[labelMapper('title')]]"></oj-bind-text></span>
   </div>
 
   <div slot="body">
-    <div class="oj-panel wkt-notop">
+    <div class="oj-panel wkt-notop wkt-full-height">
       <oj-table id="macos-environment-variables-table"
                 class="wkt-env-vars-table"
                 aria-label="Inherited Environment Variables Table"
                 data="[[environmentVariablesDataProvider]]"
                 display="grid"
+                layout="fixed"
                 horizontal-grid-visible="enabled"
                 vertical-grid-visible="enabled"
                 edit-mode="none"
@@ -28,7 +29,6 @@
               </td>
           </tr>
         </template>
-        <template slot="headerTemplate" data-oj-as="header"></template>
       </oj-table>
     </div>
   </div>

webui/src/js/views/macos-path-directories-dialog.html

@@ -2,13 +2,13 @@
  Copyright (c) 2022, Oracle and/or its affiliates.
  Licensed under The Universal Permissive License (UPL), Version 1.0 as shown at https://oss.oracle.com/licenses/upl/
  -->
-<oj-dialog id="wktMacosPathDirectoriesDialog" class="wkt-macos-path-directories-dialog" initial-visibility="hide">
+<oj-dialog id="wktMacosPathDirectoriesDialog" class="wkt-macos-path-directories-dialog wkt-fixed-body-dialog" initial-visibility="hide">
   <div slot="header">
     <span class="oj-dialog-title"><oj-bind-text value="[[labelMapper('title')]]"></oj-bind-text></span>
   </div>
 
   <div slot="body">
-    <div class="oj-panel wkt-notop">
+    <div class="oj-panel wkt-notop wkt-full-height">
       <div>
         <ol>
           <oj-bind-for-each data="[[pathDirectories]]">