some updates based on review feedback

Author: markxnelson

src/test/java/weblogic/logging/exporter/FirstTest.java

@@ -14,23 +14,25 @@
 @DisplayName("Test the Result object")
 public class ResultTest {
 
+  // using 200 for status field just to test it is set/got correctly
+  // 200 is HTTP status for OK
   private static final String EXPECTED_STRING =
-      "Result{response='good', status=1, successful=true}";
+      "Result{response='good', status=200, successful=true}";
 
-  @DisplayName("Check constructor and getters")
+  @DisplayName("After creating a Result, make sure I can retrieve the field values")
   @Test
-  public void testConstructorAndGetters() {
-    Result result = new Result("good", 1, true);
+  public void afterCreated_canRetrieveFieldValues() {
+    Result result = new Result("good", 200, true);
 
     assertEquals("good", result.getResponse());
-    assertEquals(1, result.getStatus());
+    assertEquals(200, result.getStatus());
     assertEquals(true, result.isSuccessful());
   }
 
   @DisplayName("Check toString() works")
   @Test
   public void checkToString() {
-    Result result = new Result("good", 1, true);
+    Result result = new Result("good", 200, true);
 
     assertEquals(EXPECTED_STRING, result.toString());
   }

src/test/java/weblogic/logging/exporter/ResultTest.java

@@ -44,53 +44,47 @@ public void whenStringArrayValueIsList_returnAsArray() {
     assertThat(MapUtils.getStringArray(map, "values"), arrayContaining("7", "8", "true"));
   }
 
-  @DisplayName("Check getBooleanValue for true values")
+  @DisplayName("After creating a map, check that 'good' true values are correctly interpreted")
   @Test
-  public void checkGetBooleanForTrueValues() {
-    Map<String, Object> map = new HashMap<>();
-    map.put("1", "true");
-    map.put("2", "t");
-    map.put("3", "yes");
-    map.put("4", "on");
-    map.put("5", "y");
-    map.put("6", "truenot");
-    map.put("7", "nottrue");
-    map.put("8", "yesss");
-    map.put("9", "y ");
-    map.put("10", " y ");
+  public void afterCreateMap_checkGoodTrueValues() {
+    Map<String, Object> map = createMapOfTrueValues();
 
     assertEquals(true, MapUtils.getBooleanValue(map, "1"));
     assertEquals(true, MapUtils.getBooleanValue(map, "2"));
     assertEquals(true, MapUtils.getBooleanValue(map, "3"));
     assertEquals(true, MapUtils.getBooleanValue(map, "4"));
     assertEquals(true, MapUtils.getBooleanValue(map, "5"));
+  }
+
+  @DisplayName("After creating a map, check that 'bad' true values are correctly interpreted")
+  @Test
+  public void afterCreateMap_checkBaddTrueValues() {
+    Map<String, Object> map = createMapOfTrueValues();
+
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "6"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "7"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "8"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "9"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "10"));
   }
 
-  @DisplayName("Check getBooleanValue for false values")
+  @DisplayName("After creating a map, check that 'good' false values are correctly interpreted")
   @Test
-  public void checkGetBooleanForFalseValues() {
-    Map<String, Object> map = new HashMap<>();
-    map.put("1", "false");
-    map.put("2", "f");
-    map.put("3", "no");
-    map.put("4", "off");
-    map.put("5", "n");
-    map.put("6", "falsedata");
-    map.put("7", "sofalse");
-    map.put("8", "ono");
-    map.put("9", "n ");
-    map.put("10", " n ");
+  public void afterCreateMap_checkGoodFalseValues() {
+    Map<String, Object> map = createMapOfFalseValues();
 
     assertEquals(false, MapUtils.getBooleanValue(map, "1"));
     assertEquals(false, MapUtils.getBooleanValue(map, "2"));
     assertEquals(false, MapUtils.getBooleanValue(map, "3"));
     assertEquals(false, MapUtils.getBooleanValue(map, "4"));
     assertEquals(false, MapUtils.getBooleanValue(map, "5"));
+  }
+
+  @DisplayName("After creating a map, check that 'bad' false values are correctly interpreted")
+  @Test
+  public void afterCreateMap_checkBadFalseValues() {
+    Map<String, Object> map = createMapOfFalseValues();
+
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "6"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "7"));
     assertThrows(ConfigurationException.class, () -> MapUtils.getBooleanValue(map, "8"));
@@ -103,4 +97,34 @@ private Map<String, Object> createMapWithValue(Object value) {
     map.put("values", value);
     return map;
   }
+
+  private Map<String, Object> createMapOfTrueValues() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("1", "true");
+    map.put("2", "t");
+    map.put("3", "yes");
+    map.put("4", "on");
+    map.put("5", "y");
+    map.put("6", "truenot");
+    map.put("7", "nottrue");
+    map.put("8", "yesss");
+    map.put("9", "y ");
+    map.put("10", " y ");
+    return map;
+  }
+
+  private Map<String, Object> createMapOfFalseValues() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("1", "false");
+    map.put("2", "f");
+    map.put("3", "no");
+    map.put("4", "off");
+    map.put("5", "n");
+    map.put("6", "falsedata");
+    map.put("7", "sofalse");
+    map.put("8", "ono");
+    map.put("9", "n ");
+    map.put("10", " n ");
+    return map;
+  }
 }