add some more tests

Author: markxnelson

pom.xml

@@ -99,6 +99,26 @@
                 <version>2.22.0</version>
             </plugin>
             <!-- end -->
+            <plugin>
+                <groupId>org.jacoco</groupId>
+                <artifactId>jacoco-maven-plugin</artifactId>
+                <version>0.8.3</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>prepare-agent</goal>
+                        </goals>
+                    </execution>
+                    <!-- attached to Maven test phase -->
+                    <execution>
+                        <id>report</id>
+                        <phase>test</phase>
+                        <goals>
+                            <goal>report</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 
@@ -186,4 +206,21 @@
             <version>3.5.2</version>
         </dependency>
     </dependencies>
+
+    <reporting>
+        <plugins>
+            <plugin>
+                <groupId>org.jacoco</groupId>
+                <artifactId>jacoco-maven-plugin</artifactId>
+                <reportSets>
+                    <reportSet>
+                        <reports>
+                            <!-- select non-aggregate reports -->
+                            <report>report</report>
+                        </reports>
+                    </reportSet>
+                </reportSets>
+            </plugin>
+        </plugins>
+    </reporting>
 </project>

src/main/java/weblogic/logging/exporter/config/Config.java

@@ -85,11 +85,9 @@ public static Config loadConfig(File file) {
     try {
       return loadConfig(new FileInputStream(file));
     } catch (FileNotFoundException e) {
-      System.out.println(file.toString() + "Not Found");
+      System.out.println(file.toString() + " Not Found");
     } catch (YamlParserException ex) {
       System.out.println("Error parsing configuration file : " + file.toString());
-    } catch (Exception ex) {
-      System.out.println("Error detected in configuration file.");
     }
     System.out.println("Using default for all parameters");
     return new Config();

src/test/java/weblogic/logging/exporter/config/ConfigTest.java

@@ -8,14 +8,42 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
+import java.io.ByteArrayOutputStream;
 import java.io.File;
+import java.io.PrintStream;
 import java.util.ArrayList;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
 @DisplayName("Test the Config class")
 public class ConfigTest {
 
+  private final ByteArrayOutputStream outContent = new ByteArrayOutputStream();
+  private final ByteArrayOutputStream errContent = new ByteArrayOutputStream();
+  private final PrintStream originalOut = System.out;
+  private final PrintStream originalErr = System.err;
+
+  private static final String EXPECTED_STRING =
+      "Config{weblogicLoggingIndexName='index1', publishHost='host1', "
+          + "publishPort=1234, weblogicLoggingExporterSeverity='Warning', "
+          + "weblogicLoggingExporterBulkSize='2', enabled=false, "
+          + "weblogicLoggingExporterFilters=[FilterConfig{expression='MSGID != 'BEA-000449'', "
+          + "servers=[]}], domainUID='domain1'}";
+
+  @BeforeEach
+  public void setUpStreams() {
+    System.setOut(new PrintStream(outContent));
+    System.setErr(new PrintStream(errContent));
+  }
+
+  @AfterEach
+  public void restoreStreams() {
+    System.setOut(originalOut);
+    System.setErr(originalErr);
+  }
+
   @DisplayName("Create the default config from an empty file")
   @Test
   public void createDefaultConfigFromEmptyFile() {
@@ -42,7 +70,7 @@ public void createConfigFromFile() {
     // create config by loading an empty file
     Config config = Config.loadConfig(new File("src/test/resources/config1.yaml"));
 
-    // now check that the config contains the expected default values
+    // now check that the config contains the expected values
     assertAll(
         "config",
         () -> assertEquals("host1", config.getHost()),
@@ -59,4 +87,37 @@ public void createConfigFromFile() {
         () -> assertEquals(2, config.getBulkSize()),
         () -> assertEquals("domain1", config.getDomainUID()));
   }
+
+  @DisplayName("Config file does not exist")
+  @Test
+  public void configFileDoesNotExist() {
+    Config config = Config.loadConfig(new File("src/test/resources/no-such-file.yaml"));
+    assertTrue(outContent.toString().contains(("Not Found")));
+    assertTrue(outContent.toString().contains("Using default for all parameters"));
+  }
+
+  @DisplayName("Config file cannot be parsed")
+  @Test
+  public void configFileCannotBeParsed() {
+    Config config = Config.loadConfig(new File("src/test/resources/bad.yaml"));
+    assertTrue(outContent.toString().contains(("Error parsing configuration file")));
+    assertTrue(outContent.toString().contains("Using default for all parameters"));
+  }
+
+  @DisplayName("Should convert index name to lower case")
+  @Test
+  public void shouldConvertIndexNameToLowerCase() {
+    // create config by loading an empty file
+    Config config = Config.loadConfig(new File("src/test/resources/config2.yaml"));
+
+    // now check that the config contains the expected values
+    assertEquals("index2", config.getIndexName());
+  }
+
+  @DisplayName("Check the toString() method works as expected")
+  @Test
+  public void checkToStringWorksAsExpected() {
+    Config config = Config.loadConfig(new File("src/test/resources/config1.yaml"));
+    assertEquals(EXPECTED_STRING, config.toString());
+  }
 }

src/test/resources/bad.yaml

@@ -0,0 +1,5 @@
+# I am not well formated
+publishHost: host1
+something else that should
+- not be here
+    at all

src/test/resources/config2.yaml

@@ -0,0 +1,12 @@
+# Test config file
+# This one has an upper case index name, which should be converted to lower case
+
+publishHost: host1
+publishPort: 1234
+weblogicLoggingExporterFilters:
+- FilterExpression:  MSGID != 'BEA-000449'
+weblogicLoggingExporterEnabled: false
+weblogicLoggingExporterSeverity: Warning
+weblogicLoggingExporterBulkSize: 2
+weblogicLoggingIndexName: INDEX2
+domainUID: domain1