add filterConfig tests

Author: markxnelson

src/test/java/weblogic/logging/exporter/config/FilterConfigTest.java

@@ -6,26 +6,91 @@
 
 package weblogic.logging.exporter.config;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.*;
 
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
 import java.util.HashMap;
 import java.util.Map;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
 @DisplayName("Test FilterConfig class")
 public class FilterConfigTest {
 
-  private static final String EXPECTED_STRING =
+  private final ByteArrayOutputStream outContent = new ByteArrayOutputStream();
+  private final ByteArrayOutputStream errContent = new ByteArrayOutputStream();
+  private final PrintStream originalOut = System.out;
+  private final PrintStream originalErr = System.err;
+
+  @BeforeEach
+  public void setUpStreams() {
+    System.setOut(new PrintStream(outContent));
+    System.setErr(new PrintStream(errContent));
+  }
+
+  @AfterEach
+  public void restoreStreams() {
+    System.setOut(originalOut);
+    System.setErr(originalErr);
+  }
+
+  private static final String EXPECTED_FILTERS_STRING =
       "FilterConfig{expression='MSGID != 'BEA-000449'', servers=[]}";
 
-  @DisplayName("Check toString() works as expected")
+  private static final String EXPECTED_SERVERS_STRING =
+      "FilterConfig{expression='null', servers=[managed-server-1]}";
+
+  @DisplayName("Check toString() works as expected for filter expressions")
+  @Test
+  public void checkToStringWorksAsExpectedForFilterExpressions() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("FilterExpression", "MSGID != 'BEA-000449'");
+    FilterConfig filterConfig = FilterConfig.create(map);
+
+    assertEquals(EXPECTED_FILTERS_STRING, filterConfig.toString());
+  }
+
+  @DisplayName("Check toString() works as expected for servers")
+  @Test
+  public void checkToStringWorksAsExpectedForServers() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("FilterServers", "managed-server-1");
+    FilterConfig filterConfig = FilterConfig.create(map);
+
+    assertEquals(EXPECTED_SERVERS_STRING, filterConfig.toString());
+  }
+
+  @DisplayName("Check the query can be retrieved")
   @Test
-  public void checkToStringWorksAsExpected() {
+  public void checkTheQuery() {
     Map<String, Object> map = new HashMap<>();
     map.put("FilterExpression", "MSGID != 'BEA-000449'");
     FilterConfig filterConfig = FilterConfig.create(map);
 
-    assertEquals(EXPECTED_STRING, filterConfig.toString());
+    assertTrue(
+        filterConfig.getQuery().toString().contains("weblogic.diagnostics.query.CompiledQuery"));
+  }
+
+  @DisplayName("Bad filter expression")
+  @Test
+  public void badFilterExpression() {
+    Map<String, Object> map = new HashMap<>();
+    map.put("FilterExpression", "nonsense-text");
+    FilterConfig filterConfig = FilterConfig.create(map);
+
+    assertTrue(outContent.toString().contains(("Error Parsing expression:")));
+  }
+
+  @DisplayName("Check duplicate values are rejected")
+  @Test
+  public void checkDuplicateValuesAreRejected() {
+    Map<String, Object> map = new HashMap<>();
+    map.put(
+        "FilterServers", new String[] {"managed-server-1", "managed-server-2", "managed-server-1"});
+
+    assertThrows(ConfigurationException.class, () -> FilterConfig.create(map));
   }
 }

src/test/resources/config3.yaml

@@ -0,0 +1,15 @@
+# Test config file
+# This one has an upper case index name, which should be converted to lower case
+
+publishHost: host1
+publishPort: 1234
+weblogicLoggingExporterFilters:
+- FilterExpression:  MSGID != 'BEA-000449'
+  FilterServers:
+  - managed-server-1
+  - managed-server-2
+weblogicLoggingExporterEnabled: false
+weblogicLoggingExporterSeverity: Warning
+weblogicLoggingExporterBulkSize: 2
+weblogicLoggingIndexName: INDEX2
+domainUID: domain1