additional changes based on Tom Barnes feedback

Author: lennyphan

operator/src/main/java/oracle/kubernetes/operator/helpers/ConfigMapHelper.java

@@ -270,7 +270,7 @@ public NextAction apply(Packet packet) {
       if (topologyYaml != null) {
         LOGGER.fine("topology.yaml: " + topologyYaml);
         DomainTopology domainTopology = parseDomainTopologyYaml(topologyYaml);
-        if (domainTopology.isDomainInvalid()) {
+        if (!domainTopology.getDomainValid()) {
           // If introspector determines Domain is invalid then log erros and terminate the fiber
           logValidationErrors(domainTopology.getValidationErrors());
           return doNext(null, packet);
@@ -590,7 +590,11 @@ public static class DomainTopology {
     private List<String> validationErrors;
 
     public boolean getDomainValid() {
-      return this.domainValid;
+      // domainValid = true AND no validation errors exist
+      if (domainValid && getValidationErrors().isEmpty()) {
+        return true;
+      }
+      return false;
     }
 
     public void setDomainValid(boolean domainValid) {
@@ -616,7 +620,7 @@ public List<String> getValidationErrors() {
         // errors from introspector.
         validationErrors = new ArrayList<>();
         validationErrors.add(
-            "Error, domain is marked invalid without error messages from introspector job.");
+            "Error, domain is invalid although there are no validation errors from introspector job.");
       }
 
       return validationErrors;
@@ -632,13 +636,5 @@ public String toString() {
       }
       return "domainValid: " + domainValid + ", validationErrors: " + validationErrors;
     }
-
-    boolean isDomainInvalid() {
-      // domainValid = false OR validation errors exist
-      if (!domainValid || !getValidationErrors().isEmpty()) {
-        return true;
-      }
-      return false;
-    }
   }
 }

operator/src/test/java/oracle/kubernetes/operator/helpers/ConfigMapHelperTest.java

@@ -567,7 +567,6 @@ public void parseMixedClusterTopologyYaml() {
 
     assertNotNull(domainTopology);
     assertTrue(domainTopology.getDomainValid());
-    assertFalse(domainTopology.isDomainInvalid());
 
     WlsDomainConfig wlsDomainConfig = domainTopology.getDomain();
     assertNotNull(wlsDomainConfig);
@@ -597,7 +596,6 @@ public void parseInvalidTopologyYamlWithValidationErrors() {
 
     assertFalse(domainTopology.getValidationErrors().isEmpty());
     assertFalse(domainTopology.getDomainValid());
-    assertTrue(domainTopology.isDomainInvalid());
     assertEquals(
         "The dynamic cluster \"mycluster\"'s dynamic servers use calculated listen ports.",
         domainTopology.getValidationErrors().get(0));
@@ -610,6 +608,5 @@ public void parseInvalidTopologyYamlWithNoValidationErrors() {
 
     assertFalse(domainTopology.getValidationErrors().isEmpty());
     assertFalse(domainTopology.getDomainValid());
-    assertTrue(domainTopology.isDomainInvalid());
   }
 }