OWLS-106777 - Fix for string index out of bounds exception in PodStepContext. (#3989)

Author: ankedia

operator/src/main/java/oracle/kubernetes/operator/helpers/PodStepContext.java

@@ -368,7 +368,7 @@ private String createContainerPortName(List<V1ContainerPort> ports, String name)
   @Nonnull
   private String getPortNamePrefix(String name) {
     // Use first 12 characters of port name as prefix due to 15 character port name limit
-    return name.substring(0, 12);
+    return name.length() > 12 ? name.substring(0, 12) : name;
   }
 
   Integer getListenPort() {

operator/src/test/java/oracle/kubernetes/operator/helpers/PodHelperTestBase.java

@@ -475,6 +475,17 @@ void whenPodCreatedWithMultipleNapsWithNamesExceedingMaxPortNameLength_podContai
                      createContainerPort(TRUNCATED_PORT_NAME_PREFIX + "-02")));
   }
 
+  @Test
+  void whenOneNapNameExceedsMaxPortNameLengthAndOtherNapWithShortName_podContainerCreatedWithCorrectPortNames() {
+    getServerTopology().addNetworkAccessPoint(new NetworkAccessPoint("shortname", "admin", 8001, 8001));
+    getServerTopology().addNetworkAccessPoint(new NetworkAccessPoint(LONG_CHANNEL_NAME + "1", "admin", 8001, 8001));
+
+    assertThat(
+        getContainerPorts(),
+        hasItems(createContainerPort(TRUNCATED_PORT_NAME_PREFIX + "-01"),
+            createContainerPort("shortname")));
+  }
+
   @Test
   void whenPodCreatedWithMultipleNapsSomeWithNamesExceedingMaxPortNameLength_podContainerCreatedWithMixedPortNames() {
     getServerTopology().addNetworkAccessPoint(new NetworkAccessPoint(LONG_CHANNEL_NAME, "admin", 8001, 8001));