OWLS-107980 - Fix for unexpected introspector failure message in the operator logs. (#4159)

* OWLS-107980 - Fix for unexpected introspector failure message in the operator logs.

Author: ankedia

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -498,7 +498,6 @@ private Step deleteIntrospectorJob() {
     }
 
     class DeleteDomainIntrospectorJobStep extends Step {
-
       @Override
       public NextAction apply(Packet packet) {
         logJobDeleted(getDomainUid(), getNamespace(), getJobName(), packet);
@@ -885,14 +884,18 @@ static void logJobDeleted(String domainUid, String namespace, String jobName, Pa
 
     packet.remove(ProcessingConstants.INTROSPECTOR_JOB_FAILURE_LOGGED);
     if (domainIntrospectorJob != null
-            && !JobWatcher.isComplete(domainIntrospectorJob)) {
+        && hasStatusAndCondition(domainIntrospectorJob) && !JobWatcher.isComplete(domainIntrospectorJob)) {
       logIntrospectorFailure(packet, domainIntrospectorJob);
     }
     packet.remove(ProcessingConstants.JOB_POD_NAME);
 
     LOGGER.fine(getJobDeletedMessageKey(), domainUid, namespace, jobName);
   }
 
+  private static boolean hasStatusAndCondition(V1Job job) {
+    return job.getStatus() != null && job.getStatus().getConditions() != null;
+  }
+
   static String getJobDeletedMessageKey() {
     return MessageKeys.JOB_DELETED;
   }

operator/src/test/java/oracle/kubernetes/operator/helpers/DomainIntrospectorJobTest.java

@@ -1317,13 +1317,25 @@ void whenIntrospectorJobNotNeeded_validateDomainAgainstPreviousTopology() throws
   }
 
   @Test
-  void whenJobLogContainsSevereError_logJobInfosOnDelete() {
+  void whenJobStatusContainsNoConditions_dontLogJobFailedAndInfosOnDelete() {
     testSupport.defineResources(createIntrospectorJob());
     IntrospectionTestUtils.defineIntrospectionPodLog(testSupport, SEVERE_MESSAGE);
     testSupport.addToPacket(DOMAIN_INTROSPECTOR_JOB, testSupport.getResourceWithName(JOB, getJobName()));
 
     testSupport.runSteps(JobHelper.deleteDomainIntrospectorJobStep(null));
 
+    assertThat(logRecords, not(containsInfo(getJobFailedMessageKey())));
+    assertThat(logRecords, not(containsFine(getJobFailedDetailMessageKey())));
+    assertThat(logRecords, containsFine(getJobDeletedMessageKey()));
+  }
+
+  @Test
+  void whenJobStatusHasFailedCondition_logJobInfosOnDelete() {
+    testSupport.defineResources(asFailedJob(createIntrospectorJob()));
+    testSupport.addToPacket(DOMAIN_INTROSPECTOR_JOB, testSupport.getResourceWithName(JOB, getJobName()));
+
+    testSupport.runSteps(JobHelper.deleteDomainIntrospectorJobStep(null));
+
     assertThat(logRecords, containsInfo(getJobFailedMessageKey()));
     assertThat(logRecords, containsFine(getJobFailedDetailMessageKey()));
     assertThat(logRecords, containsFine(getJobDeletedMessageKey()));