Correct ByServers constant in NM script and remove default for logHomeLayout

Author: rjeberhard

documentation/domains/Domain.json

@@ -313,7 +313,6 @@
           "minimum": 1
         },
         "logHomeLayout": {
-          "default": "ByServers",
           "description": "Control how log files under `logHome` are organized when logHome is set and `logHomeEnabled` is true. `Flat` specifies that all files are kept directly in the `logHome` root directory. `ByServers` specifies that domain log files and `introspector.out` are at the `logHome` root level, all other files are organized under the respective server name logs directory  `logHome/servers/\u003cserver name\u003e/logs`. Defaults to `ByServers`.",
           "type": "string",
           "enum": [

kubernetes/crd/domain-crd.yaml

@@ -5,7 +5,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    weblogic.sha256: f65b4f29f490db1bbe4238ea6be340a514a236d4654b858a1136270132239c62
+    weblogic.sha256: 40333b90cd079349282d5038a27c045388ea7df3cb112116c79a74974b142cc9
   name: domains.weblogic.oracle
 spec:
   group: weblogic.oracle
@@ -519,7 +519,6 @@ spec:
                 minimum: 1
                 type: integer
               logHomeLayout:
-                default: ByServers
                 description: Control how log files under `logHome` are organized when
                   logHome is set and `logHomeEnabled` is true. `Flat` specifies that
                   all files are kept directly in the `logHome` root directory. `ByServers`

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainSpec.java

@@ -127,7 +127,6 @@ public class DomainSpec extends BaseConfiguration {
         + "`ByServers` specifies that domain log files and `introspector.out` are at the `logHome` root level, "
         + "all other files are organized under the respective server name logs directory  "
         + "`logHome/servers/<server name>/logs`. Defaults to `ByServers`.")
-  @Default(strDefault = "ByServers")
   private LogHomeLayoutType logHomeLayout = LogHomeLayoutType.BY_SERVERS;
 
 

operator/src/main/resources/scripts/startNodeManager.sh

@@ -133,7 +133,7 @@ if [ "${SERVER_NAME}" = "introspector" ]; then
 else
   # setup ".out" location for a WL server
   serverLogHome="${LOG_HOME:-${DOMAIN_HOME}}"
-  if [ -z ${LOG_HOME_LAYOUT} ] || [ "BY_SERVERS" = ${LOG_HOME_LAYOUT} ] ; then
+  if [ -z ${LOG_HOME} ] || [ "ByServers" = ${LOG_HOME_LAYOUT} ] ; then
     serverLogHome="${serverLogHome}/servers/${SERVER_NAME}/logs"
   fi
   export SERVER_OUT_FILE="${serverLogHome}/${SERVER_NAME}.out"