Merge pull request #342 from oracle/issue-341

Per-server instance services specify "None" for clusterIP if type is ClusterIP

Author: rjeberhard

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

@@ -97,6 +97,9 @@ protected V1ServiceSpec createServiceSpec() {
       if (isPublishNotReadyAddressesSupported()) {
         serviceSpec.setPublishNotReadyAddresses(Boolean.TRUE);
       }
+      if (nodePort == null) {
+        serviceSpec.clusterIP("None");
+      }
       return serviceSpec;
     }
 

operator/src/test/java/oracle/kubernetes/operator/helpers/ServiceHelperTest.java

@@ -442,7 +442,7 @@ public void whenNodePortSpecified_createServerServiceWithNodePort() {
   }
 
   private V1Service withNodePort(V1Service service, int nodePort) {
-    service.getSpec().setType("NodePort");
+    service.getSpec().type("NodePort").clusterIP(null);
     service
         .getSpec()
         .getPorts()
@@ -530,7 +530,7 @@ private ServerKubernetesObjects getServerKubernetesObjects() {
   }
 
   private V1ServiceSpec createServerServiceSpec() {
-    return createUntypedServerServiceSpec().type("ClusterIP");
+    return createUntypedServerServiceSpec().type("ClusterIP").clusterIP("None");
   }
 
   private V1ServiceSpec createUntypedServerServiceSpec() {