Update JUnit classes and test methods to be non-public (#2492)

Author: rjeberhard

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItCoherenceTests.java

@@ -132,7 +132,7 @@ public static void init(@Namespaces(2) List<String> namespaces) {
    */
   @Test
   @DisplayName("Create domain with a Coherence cluster using WDT and test rolling restart")
-  public void testCoherenceServerRollingRestart() {
+  void testCoherenceServerRollingRestart() {
     final String successMarker = "CACHE-SUCCESS";
 
     // create a DomainHomeInImage image using WebLogic Image Tool

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItConfigDistributionStrategy.java

@@ -118,7 +118,7 @@
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 @DisplayName("Verify the overrideDistributionStrategy applies the overrides accordingly to the value set")
 @IntegrationTest
-public class ItConfigDistributionStrategy {
+class ItConfigDistributionStrategy {
 
   private static String opNamespace = null;
   private static String domainNamespace = null;
@@ -269,7 +269,7 @@ public void afterEach() {
   @Order(1)
   @Test
   @DisplayName("Test overrideDistributionStrategy set to DEFAULT")
-  public void testDefaultOverride() {
+  void testDefaultOverride() {
 
     //store the pod creation timestamps
     storePodCreationTimestamps();
@@ -325,7 +325,7 @@ public void testDefaultOverride() {
   @Order(2)
   @Test
   @DisplayName("Test new overrides are applied as per the files in recreated configmap")
-  public void testModifiedOverrideContent() {
+  void testModifiedOverrideContent() {
 
     //store the pod creation timestamps
     storePodCreationTimestamps();
@@ -434,7 +434,7 @@ public void testModifiedOverrideContent() {
   @Order(3)
   @Test
   @DisplayName("Test overrideDistributionStrategy value DYNAMIC")
-  public void testDynamicOverride() {
+  void testDynamicOverride() {
 
     //patching the domain with /spec/configuration/overrideDistributionStrategy: DYNAMIC
     String patchStr = "["
@@ -512,7 +512,7 @@ public void testDynamicOverride() {
   @Order(4)
   @Test
   @DisplayName("Test overrideDistributionStrategy value ON_RESTART")
-  public void testOnRestartOverride() {
+  void testOnRestartOverride() {
 
     //patching the domain with /spec/configuration/overrideDistributionStrategy: ON_RESTART
     String patchStr = "["
@@ -616,7 +616,7 @@ public void testOnRestartOverride() {
   @Order(5)
   @Test
   @DisplayName("Test invalid overrideDistributionStrategy value RESTART")
-  public void testOverrideNegative() {
+  void testOverrideNegative() {
 
     //patching the domain with /spec/configuration/overrideDistributionStrategy: RESTART
     String patchStr = "["

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItCrossDomainTransaction.java

@@ -86,7 +86,7 @@
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 @DisplayName("Verify cross domain transaction is successful")
 @IntegrationTest
-public class ItCrossDomainTransaction {
+class ItCrossDomainTransaction {
 
   private static final String WDT_MODEL_FILE_DOMAIN1 = "model-crossdomaintransaction-domain1.yaml";
   private static final String WDT_MODEL_FILE_DOMAIN2 = "model-crossdomaintransaction-domain2.yaml";
@@ -346,7 +346,7 @@ private static void buildApplicationsAndDomains() {
   @Order(1)
   @Test
   @DisplayName("Check cross domain transaction works")
-  public void testCrossDomainTransaction() {
+  void testCrossDomainTransaction() {
 
     String curlRequest = String.format("curl -v --show-error --noproxy '*' "
             + "http://%s:%s/TxForward/TxForward?urls=t3://%s.%s:7001,t3://%s1.%s:8001,t3://%s1.%s:8001,t3://%s2.%s:8001",
@@ -381,7 +381,7 @@ public void testCrossDomainTransaction() {
   @Order(2)
   @Test
   @DisplayName("Check cross domain transaction with TMAfterTLogBeforeCommitExit property commits")
-  public void testCrossDomainTransactionWithFailInjection() {
+  void testCrossDomainTransactionWithFailInjection() {
 
     String curlRequest = String.format("curl -v --show-error --noproxy '*' "
             + "http://%s:%s/cdttxservlet/cdttxservlet?namespaces=%s,%s",
@@ -418,7 +418,7 @@ public void testCrossDomainTransactionWithFailInjection() {
   @Order(3)
   @Test
   @DisplayName("Check cross domain transcated MDB communication ")
-  public void testCrossDomainTranscatedMDB() {
+  void testCrossDomainTranscatedMDB() {
 
     // No extra header info
     assertTrue(checkAppIsActive(K8S_NODEPORT_HOST,domain1AdminServiceNodePort,

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItDedicatedMode.java

@@ -152,7 +152,7 @@ public void tearDownAll() {
   @Order(1)
   @DisplayName("Set domainNamespaceSelectionStrategy to Dedicated for the Operator Helm Chart and "
       + "verify that a domain not deployed in operator's namespace doesn't come up")
-  public void testDedicatedModeDiffNamespace() {
+  void testDedicatedModeDiffNamespace() {
     // install and verify operator
     logger.info("Installing and verifying operator");
     installAndVerifyOperator(opNamespace, opNamespace + "-sa",
@@ -177,7 +177,7 @@ public void testDedicatedModeDiffNamespace() {
   @Order(2)
   @DisplayName("Set domainNamespaceSelectionStrategy to Dedicated for the Operator Helm Chart and "
       + "verify that the domain deployed in the operator's namespace comes up")
-  public void testDedicatedModeSameNamespace() {
+  void testDedicatedModeSameNamespace() {
     // create and verify the domain
     logger.info("Creating and verifying model in image domain");
     createDomain(domain1Namespace);
@@ -191,7 +191,7 @@ public void testDedicatedModeSameNamespace() {
   @Test
   @Order(3)
   @DisplayName("Scale up cluster-1 in domain1Namespace and verify it succeeds")
-  public void testDedicatedModeSameNamespaceScale() {
+  void testDedicatedModeSameNamespaceScale() {
     // scale the cluster and check domain can be managed from the operator
     int externalRestHttpsPort = getServiceNodePort(opNamespace, "external-weblogic-operator-svc");
     logger.info("externalRestHttpsPort {0}", externalRestHttpsPort);
@@ -213,7 +213,7 @@ public void testDedicatedModeSameNamespaceScale() {
   @Order(4)
   @Disabled("Disable the test because the Operator has permission to overwrite the CRD")
   @DisplayName("Create a CRD with a lower than expected version and verify that Operator fails with error")
-  public void testDedicatedModeNlowerVersionCrd() {
+  void testDedicatedModeNlowerVersionCrd() {
     // delete existing CRD
     new Command()
         .withParams(new CommandParams()
@@ -251,7 +251,7 @@ public void testDedicatedModeNlowerVersionCrd() {
   @Order(5)
   @Disabled("Disable the test because the Operator has permission to create the CRD")
   @DisplayName("Delete the CRD and verify that Operator fails with error")
-  public void testDedicatedModeNoCrd() {
+  void testDedicatedModeNoCrd() {
     // delete existing CRD
     logger.info("Delete existing CRD");
     new Command()

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItElasticLogging.java

@@ -229,7 +229,7 @@ void tearDown() {
    */
   @Test
   @DisplayName("Use Elasticsearch Count API to query logs of level=INFO and verify")
-  public void testLogLevelSearch() {
+  void testLogLevelSearch() {
     // Verify that number of logs is not zero and failed count is zero
     String regex = ".*count\":(\\d+),.*failed\":(\\d+)";
     String queryCriteria = "/_count?q=level:INFO";
@@ -245,7 +245,7 @@ public void testLogLevelSearch() {
    */
   @Test
   @DisplayName("Use Elasticsearch Search APIs to query Operator log info and verify")
-  public void testOperatorLogSearch() {
+  void testOperatorLogSearch() {
     // Verify that log occurrence for Operator are not empty
     String regex = ".*took\":(\\d+),.*hits\":\\{(.+)\\}";
     String queryCriteria = "/_search?q=type:weblogic-operator";
@@ -262,7 +262,7 @@ public void testOperatorLogSearch() {
   @Disabled("Disabled the test due to JIRA OWLS-83899")
   @Test
   @DisplayName("Use Elasticsearch Search APIs to query Operator log info and verify")
-  public void testWebLogicLogSearch() {
+  void testWebLogicLogSearch() {
     // Verify that the admin status of "RUNNING" is found in query return from Elasticsearch repository
     verifyServerRunningInSearchResults(adminServerPodName);
 
@@ -278,7 +278,7 @@ public void testWebLogicLogSearch() {
    */
   @Test
   @DisplayName("Use Elasticsearch Search APIs to query WebLogic log info in WLS server pod and verify")
-  public void testWlsLoggingExporter() throws Exception {
+  void testWlsLoggingExporter() throws Exception {
     Map<String, String> wlsMap = verifyLoggingExporterReady(opNamespace, null, WEBLOGIC_INDEX_KEY);
     // merge testVarMap and wlsMap
     testVarMap.putAll(wlsMap);

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItElasticLoggingFluentd.java

@@ -228,7 +228,7 @@ void tearDown() {
    */
   @Test
   @DisplayName("Use Fluentd to send log information to Elasticsearch and verify")
-  public void testFluentdQuery() {
+  void testFluentdQuery() {
     // Verify that number of logs is not zero and failed if count is zero
     String regex = ".*count\":(\\d+),.*failed\":(\\d+)";
     String queryCriteria = "/_count?q=serverName:" + adminServerPodName;

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItExternalLbTunneling.java

@@ -265,7 +265,7 @@ public void beforeEach() {
   @Order(1)
   @Test
   @DisplayName("Verify RMI access to WLS through Voyager LoadBalancer")
-  public void testExternalRmiAccessThruVoyager() {
+  void testExternalRmiAccessThruVoyager() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     // Build the standalone JMS Client to send and receive messages
@@ -315,7 +315,7 @@ public void testExternalRmiAccessThruVoyager() {
   @Order(2)
   @Test
   @DisplayName("Verify RMI access to WLS through Traefik LoadBalancer")
-  public void testExternalRmiAccessThruTraefik() {
+  void testExternalRmiAccessThruTraefik() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     // Build the standalone JMS Client to send and receive messages
@@ -371,7 +371,7 @@ public void testExternalRmiAccessThruTraefik() {
   @Order(3)
   @Test
   @DisplayName("Verify RMI access WLS through NGINX LoadBalancer")
-  public void testExternalRmiAccessThruNginx() {
+  void testExternalRmiAccessThruNginx() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     logger.info("Installing Nginx controller using helm");
@@ -435,7 +435,7 @@ public void testExternalRmiAccessThruNginx() {
   @Order(4)
   @Test
   @DisplayName("Verify tls RMI access WLS through Voyager loadBalancer")
-  public void testExternalRmiAccessThruVoyagerHttpsTunneling() {
+  void testExternalRmiAccessThruVoyagerHttpsTunneling() {
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     // Build the standalone JMS Client to send and receive messages
     buildClient();
@@ -479,7 +479,7 @@ public void testExternalRmiAccessThruVoyagerHttpsTunneling() {
   @Order(5)
   @Test
   @DisplayName("Verify tls RMI access WLS through Traefik loadBalancer")
-  public void testExternalRmiAccessThruTraefikHttpsTunneling() {
+  void testExternalRmiAccessThruTraefikHttpsTunneling() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
 
@@ -530,7 +530,7 @@ public void testExternalRmiAccessThruTraefikHttpsTunneling() {
   @Order(6)
   @Test
   @DisplayName("Verify tls RMI access WLS through NGNIX loadBalancer")
-  public void testExternalRmiAccessThruNginxHttpsTunneling() {
+  void testExternalRmiAccessThruNginxHttpsTunneling() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     logger.info("Installing Nginx controller using helm");

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItExternalNodePortService.java

@@ -211,7 +211,7 @@ public void beforeEach() {
    */
   @Test
   @DisplayName("Verify RMI access to WLS through NodePort Service")
-  public void testExternalRmiAccessThruNodePortService() {
+  void testExternalRmiAccessThruNodePortService() {
 
     assumeFalse(WEBLOGIC_SLIM, "Skipping RMI Tunnelling Test for slim image");
     // Build the standalone JMS Client to send and receive messages

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItFmwBigCMMiiDomain.java

@@ -62,7 +62,7 @@
 @DisplayName("Test to a create FMW model in image domain "
     + "with introspect Config Map bigger then 1 Mb and start the domain")
 @IntegrationTest
-public class ItFmwBigCMMiiDomain {
+class ItFmwBigCMMiiDomain {
 
   private static String dbNamespace = null;
   private static String opNamespace = null;
@@ -150,7 +150,7 @@ RCUSCHEMAPREFIX, dbNamespace, getNextFreePort(), dbUrl),
    */
   @Test
   @DisplayName("Create FMW Domain model in image with big introspector CM")
-  public void testFmwBigCMModelInImage() {
+  void testFmwBigCMModelInImage() {
 
     // Create the repo secret to pull the image
     // this secret is used only for non-kind cluster

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItFmwDiiSample.java

@@ -156,7 +156,7 @@ public static void initAll(@Namespaces(3) List<String> namespaces) {
   @ParameterizedTest
   @MethodSource("paramProvider")
   @DisplayName("Test FMW domain in image sample")
-  public void testFmwDomainInImageSample(String model) {
+  void testFmwDomainInImageSample(String model) {
     String domainUid = model.split(":")[1];
     String script = model.split(":")[0]; // wlst | wdt way of creating domain