Use tcp prefix for metrics exporter (#2408)

Author: rjeberhard

operator/src/main/java/oracle/kubernetes/operator/helpers/PodStepContext.java

@@ -1337,7 +1337,7 @@ private V1Container createMonitoringExporterContainer() {
     }
 
     private String getMetricsPortName() {
-      return getDomain().isIstioEnabled() ? "http-metrics" : "metrics";
+      return getDomain().isIstioEnabled() ? "tcp-metrics" : "metrics";
     }
 
     private String createJavaOptions() {

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

@@ -426,7 +426,7 @@ void addServicePorts(List<V1ServicePort> ports, WlsServerConfig serverConfig) {
     }
 
     private String getMetricsPortName() {
-      return getDomain().isIstioEnabled() ? "http-metrics" : "metrics";
+      return getDomain().isIstioEnabled() ? "tcp-metrics" : "metrics";
     }
 
     List<NetworkAccessPoint> getNetworkAccessPoints(@Nonnull WlsServerConfig config) {

operator/src/main/java/oracle/kubernetes/operator/steps/MonitoringExporterSteps.java

@@ -278,7 +278,7 @@ Domain getDomain() {
     }
 
     private String getMetricsPortName() {
-      return getDomain().isIstioEnabled() ? "http-metrics" : "metrics";
+      return getDomain().isIstioEnabled() ? "tcp-metrics" : "metrics";
     }
 
     private HttpRequest createConfigurationQueryRequest() {

operator/src/test/java/oracle/kubernetes/operator/helpers/ManagerServerServiceHelperTest.java

@@ -83,6 +83,6 @@ void whenDomainHasMonitoringExporterConfigurationAndIstio_serviceHasExporterPort
 
     V1Service service = createService();
 
-    assertThat(service, containsPort("http-metrics", DEFAULT_EXPORTER_SIDECAR_PORT));
+    assertThat(service, containsPort("tcp-metrics", DEFAULT_EXPORTER_SIDECAR_PORT));
   }
 }

operator/src/test/java/oracle/kubernetes/operator/helpers/PodHelperTestBase.java

@@ -453,7 +453,7 @@ void whenExporterContainerCreatedWithPort_hasMetricsPortsItem() {
   void whenExporterContainerCreatedAndIstioEnabled_hasMetricsPortsItem() {
     defineExporterConfiguration().withIstio();
 
-    V1ContainerPort metricsPort = getExporterContainerPort("http-metrics");
+    V1ContainerPort metricsPort = getExporterContainerPort("tcp-metrics");
     assertThat(metricsPort, notNullValue());
     assertThat(metricsPort.getProtocol(), equalTo("TCP"));
     assertThat(metricsPort.getContainerPort(), equalTo(DEFAULT_EXPORTER_SIDECAR_PORT));