address pull request comments by removing unused codes

Author: alai8

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

@@ -99,17 +99,10 @@ public NextAction apply(Packet packet) {
       List<V1ServicePort> ports = new ArrayList<>();
       V1ServicePort servicePort = new V1ServicePort();
       servicePort.setPort(port);
-      servicePort.setName("weblogic");
       if (nodePort != null) {
         servicePort.setNodePort(nodePort);
       }
       ports.add(servicePort);
-
-      V1ServicePort nmPort = new V1ServicePort();
-      nmPort.setPort(5556);
-      nmPort.setName("node-manager");
-      ports.add(nmPort);
-
       serviceSpec.setPorts(ports);
       service.setSpec(serviceSpec);
 

operator/src/main/java/oracle/kubernetes/operator/wlsconfig/WlsDomainConfig.java

@@ -16,7 +16,7 @@
 import java.util.Map;
 
 /**
- * Contains a snapsot of configuration for a WebLogic Domain
+ * Contains a snapshot of configuration for a WebLogic Domain
  */
 public class WlsDomainConfig {
   private static final LoggingFacade LOGGER = LoggingFactory.getLogger("Operator", "Operator");

operator/src/main/java/oracle/kubernetes/operator/wlsconfig/WlsRetriever.java

@@ -471,50 +471,6 @@ private String executePostUrlWithRetry(final String url, final String payload, f
     return jsonResult;
   }
 
-  /**
-   * Update the dynamic cluster size of the WLS cluster configuration.
-   *
-   * @param wlsClusterConfig The WlsClusterConfig object of the WLS cluster whose cluster size needs to be updated
-   * @param machineNamePrefix Prefix of names of new machines to be created
-   * @param targetClusterSize The target dynamic cluster size
-   * @return true if the request to update the cluster size is successful, false if it was not successful within the
-   *         time period, or the cluster is not a dynamic cluster
-   */
-  public boolean updateDynamicClusterSize(final WlsClusterConfig wlsClusterConfig,
-                                          final String machineNamePrefix,
-                                          final int targetClusterSize) {
-
-    LOGGER.entering();
-
-    final long timeout = UPDATE_CONFIG_TIMEOUT_MILLIS;
-
-    String clusterName = wlsClusterConfig == null? "null": wlsClusterConfig.getClusterName();
-
-    if (wlsClusterConfig == null || !wlsClusterConfig.hasDynamicServers()) {
-      LOGGER.warning(MessageKeys.WLS_UPDATE_CLUSTER_SIZE_INVALID_CLUSTER, clusterName);
-      return false;
-    }
-
-    ScheduledExecutorService executorService = ContainerResolver.getInstance().getContainer().getSPI(ScheduledExecutorService.class);
-    long startTime = System.currentTimeMillis();
-    Future<Boolean> future = executorService.submit(() -> doUpdateDynamicClusterSize(wlsClusterConfig, machineNamePrefix, targetClusterSize));
-    boolean result = false;
-    try {
-      result = future.get(timeout, TimeUnit.MILLISECONDS);
-      if (result) {
-        LOGGER.info(MessageKeys.WLS_CLUSTER_SIZE_UPDATED, clusterName, targetClusterSize, (System.currentTimeMillis() - startTime));
-      } else {
-        LOGGER.warning(MessageKeys.WLS_UPDATE_CLUSTER_SIZE_FAILED, clusterName,  null);
-      }
-    } catch (InterruptedException | ExecutionException e) {
-      LOGGER.warning(MessageKeys.WLS_UPDATE_CLUSTER_SIZE_FAILED, clusterName,  e);
-    } catch (TimeoutException e) {
-      LOGGER.warning(MessageKeys.WLS_UPDATE_CLUSTER_SIZE_TIMED_OUT, clusterName, timeout);
-    }
-    LOGGER.exiting(result);
-    return result;
-  }
-
   /**
    * Method called by the Callable that is submitted from the updateDynamicClusterSize method for updating the
    * WLS dynamic cluster size configuration.