Skip to content

Commit 96b8b13

Browse files
committed
fixed bug that caused the create operations to be unable to find the WDT installer when specifying a platform different from the host
1 parent 7958a57 commit 96b8b13

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/CreateAuxImage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public CommandResponse call() throws Exception {
4141

4242
copyOptionsFromImage();
4343

44-
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir());
44+
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir(), getTargetArchitecture());
4545

4646
// Create Dockerfile
4747
String dockerfile = Utils.writeDockerfile(buildDir() + File.separator + "Dockerfile",

imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/CreateImage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public CommandResponse call() throws Exception {
3535
prepareNewImage();
3636

3737
// build wdt args if user passes --wdtModelPath
38-
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir());
38+
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir(), getTargetArchitecture());
3939

4040
// Create Dockerfile
4141
String dockerfile = Utils.writeDockerfile(buildDir() + File.separator + "Dockerfile",

imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/UpdateImage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public CommandResponse call() throws Exception {
139139
BuildCommand cmdBuilder = getInitialBuildCmd(buildDir());
140140

141141
// build wdt args if user passes --wdtModelPath
142-
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir());
142+
wdtOptions.handleWdtArgs(dockerfileOptions, buildDir(), getTargetArchitecture());
143143
dockerfileOptions.setWdtCommand(wdtOperation);
144144
if (dockerfileOptions.runRcu()
145145
&& (wdtOperation == WdtOperation.UPDATE || wdtOperation == WdtOperation.DEPLOY)) {

imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/WdtBaseOptions.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import com.oracle.weblogic.imagetool.installer.InstallerType;
1616
import com.oracle.weblogic.imagetool.logging.LoggingFacade;
1717
import com.oracle.weblogic.imagetool.logging.LoggingFactory;
18+
import com.oracle.weblogic.imagetool.util.Architecture;
1819
import com.oracle.weblogic.imagetool.util.DockerfileOptions;
1920
import com.oracle.weblogic.imagetool.util.Utils;
2021
import picocli.CommandLine.Option;
@@ -57,7 +58,8 @@ public String wdtModelHome() {
5758
* @param tmpDir the tmp directory which is passed to docker as the build context directory
5859
* @throws IOException in case of error
5960
*/
60-
public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir) throws IOException {
61+
public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir, Architecture architecture)
62+
throws IOException {
6163
logger.entering(tmpDir);
6264

6365
if (!userProvidedFiles() && skipWdtInstaller()) {
@@ -84,7 +86,7 @@ public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir) th
8486
}
8587

8688
if (!skipWdtInstaller()) {
87-
CachedFile wdtInstaller = new CachedFile(InstallerType.WDT, wdtVersion);
89+
CachedFile wdtInstaller = new CachedFile(InstallerType.WDT, wdtVersion, architecture);
8890
Path wdtfile = wdtInstaller.copyFile(cache(), tmpDir);
8991
dockerfileOptions.setWdtInstallerFilename(wdtfile.getFileName().toString());
9092
}

imagetool/src/main/java/com/oracle/weblogic/imagetool/cli/menu/WdtFullOptions.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
import com.oracle.weblogic.imagetool.logging.LoggingFacade;
1111
import com.oracle.weblogic.imagetool.logging.LoggingFactory;
12+
import com.oracle.weblogic.imagetool.util.Architecture;
1213
import com.oracle.weblogic.imagetool.util.DockerfileOptions;
1314
import com.oracle.weblogic.imagetool.util.DomainHomeSourceType;
1415
import com.oracle.weblogic.imagetool.util.ResourceTemplateOptions;
@@ -36,7 +37,8 @@ public boolean modelOnly() {
3637
* @throws IOException in case of error
3738
*/
3839
@Override
39-
public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir) throws IOException {
40+
public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir, Architecture architecture)
41+
throws IOException {
4042
logger.entering(tmpDir);
4143
if (!userProvidedFiles()) {
4244
// user did not provide any WDT files, nothing to do for WDT.
@@ -48,7 +50,7 @@ public void handleWdtArgs(DockerfileOptions dockerfileOptions, String tmpDir) th
4850
throw new IllegalArgumentException(Utils.getMessage("IMG-0103"));
4951
}
5052
// user provided WDT files and a WDT installer, so call WdtBaseOptions.handleWdtArgs
51-
super.handleWdtArgs(dockerfileOptions, tmpDir);
53+
super.handleWdtArgs(dockerfileOptions, tmpDir, architecture);
5254

5355
String encryptionKey = Utils.getPasswordFromInputs(encryptionKeyStr, encryptionKeyFile, encryptionKeyEnv);
5456
if (encryptionKey != null) {

0 commit comments

Comments
 (0)