remove OPatch patch filter selecting recommended flag, OPatch and FMW are not updating this flag reliably. (#331)

Author: ddsharpe

imagetool/src/main/java/com/oracle/weblogic/imagetool/cachestore/OPatchFile.java

@@ -81,13 +81,8 @@ public static OPatchFile getInstance(String patchId, String userid, String passw
         } else {
             // Sort the patches list from highest to lowest (newest to oldest)
             List<AruPatch> sortedList = patches.stream().sorted(Comparator.reverseOrder()).collect(Collectors.toList());
-            // Select the first recommended patch, if there is one marked as recommended
-            selectedPatch = sortedList.stream().filter(AruPatch::isRecommended).findFirst().orElse(null);
-            if (selectedPatch == null) {
-                // nothing is marked as recommended, return the newest (highest numbered) patch
-                selectedPatch = sortedList.stream().findFirst().orElse(null);
-                // since patches list cannot be empty here, this findFirst should never return null
-            }
+            // Select the newest (highest numbered) patch
+            selectedPatch = sortedList.stream().findFirst().orElse(null);
         }
         logger.exiting(selectedPatch);
         return new OPatchFile(selectedPatch, userid, password);

imagetool/src/test/java/com/oracle/weblogic/imagetool/cachestore/PatchFileTest.java

@@ -344,7 +344,7 @@ void opatchDefaultTest() throws Exception {
          *     There are 5 versions of the OPatch patch.
          *     The user does not specify a version.
          * Expected:
-         *     The recommended OPatch version from ARU should be selected.
+         *     The tool ignores the recommended flag and selects the highest version number (latest).
          */
 
         // 28186730 has multiple patches available, but none are specified
@@ -354,8 +354,8 @@ void opatchDefaultTest() throws Exception {
         String filePath = patchFile.resolve(cacheStore);
 
         assertNotNull(filePath, "Patch resolve() failed to get file path from XML");
-        assertEquals("13.9.4.2.4", patchFile.getVersion(), "wrong version selected");
-        String filePathFromCache = cacheStore.getValueFromCache("28186730_13.9.4.2.4");
+        assertEquals("13.9.4.2.5", patchFile.getVersion(), "wrong version selected");
+        String filePathFromCache = cacheStore.getValueFromCache("28186730_13.9.4.2.5");
         assertNotNull(filePathFromCache, "Could not find new patch in cache");
         assertEquals(filePath, filePathFromCache, "Patch in cache does not match");
     }