update checkstyle and checker XML to newest release (#133)

Author: ddsharpe

build-tools/src/main/resources/weblogic-image-tool/checkstyle/customized_google_checks.xml

@@ -74,6 +74,12 @@ private static String getJarNameFromInstaller(Path installerFile) throws IOExcep
         return filename;
     }
 
+    /**
+     * Copy all necessary installers to the build context directory.
+     * @param cacheStore cache where the installers are defined.
+     * @param buildContextDir the directory where the installers should be copied.
+     * @throws IOException if any of the copy commands fails.
+     */
     public void copyFiles(CacheStore cacheStore, String buildContextDir) throws IOException {
         logger.entering();
         for (MiddlewareInstallPackage installPackage: installerFiles) {

imagetool/src/main/java/com/oracle/weblogic/imagetool/installer/MiddlewareInstall.java

@@ -17,6 +17,11 @@ public class LoggingFacade {
     private static final String CLASS = LoggingFacade.class.getName();
     private final Logger logger;
 
+    /**
+     * Create an Image Tool facade for the java.util.logging.Logger class.
+     * This facade is used to override the logging methods in order to infer caller details.
+     * @param logger the named logger to wrap.
+     */
     public LoggingFacade(Logger logger) {
         this.logger = logger;
 

imagetool/src/main/java/com/oracle/weblogic/imagetool/logging/LoggingFacade.java

@@ -424,10 +424,11 @@ private static String getPatchInfo(String bugNumber, String userId, String passw
             Document allPatches = HttpUtil.getXMLContent(url, userId, password);
 
             String xpath;
-            if (optionalRelease != null)
+            if (optionalRelease != null) {
                 xpath = String.format("/results/patch/release[@name='%s']/@id", optionalRelease);
-            else
+            } else {
                 xpath = "/results/patch/release/@id";
+            }
 
             logger.finest("applying xpath: " + xpath);
             String releaseNumber = XPathUtil.applyXPathReturnString(allPatches, xpath);
@@ -552,8 +553,9 @@ private static Document createResultDocument(NodeList nodeList) throws IOExcepti
                 Node n = nodeList.item(i);
                 Node copyNode = doc.importNode(n, true);
 
-                if (n instanceof Element)
+                if (n instanceof Element) {
                     element.appendChild(copyNode);
+                }
             }
 
             doc.appendChild(element);

imagetool/src/main/java/com/oracle/weblogic/imagetool/util/ARUUtil.java

@@ -279,6 +279,10 @@ public String wdt_home() {
         return wdtHome;
     }
 
+    /**
+     * The directory for the WORKDIR in the Docker build.
+     * @return the value for the WORKDIR
+     */
     @SuppressWarnings("unused")
     public String work_dir() {
         if ((isWdtEnabled() && !modelOnly()) || sourceImage != null) {
@@ -315,7 +319,10 @@ public void setInvLoc(String value) {
         }
     }
 
-
+    /**
+     * Set the value for the Oracle Inventory directory.
+     * @param value the value for inventory file (directory)
+     */
     public void setOraInvDir(String value) {
         if (value != null) {
             oraInvDir = value;

imagetool/src/main/java/com/oracle/weblogic/imagetool/util/DockerfileOptions.java

@@ -804,6 +804,12 @@ public static String getMessage(@PropertyKey(resourceBundle = "ImageTool") Strin
         return MessageFormat.format(bundle.getString(key), params);
     }
 
+    /**
+     * Remove the intermediate images created by the multi-stage Docker build.
+     * @param buildId the build ID used to identify the images created during this build.
+     * @throws IOException if the external Docker command fails.
+     * @throws InterruptedException if this program was interrupted waiting on the Docker command.
+     */
     public static void removeIntermediateDockerImages(String buildId) throws IOException, InterruptedException {
         logger.entering();
         final List<String> command = Stream.of(

imagetool/src/main/java/com/oracle/weblogic/imagetool/util/Utils.java

@@ -223,7 +223,7 @@
                         <dependency>
                             <groupId>com.puppycrawl.tools</groupId>
                             <artifactId>checkstyle</artifactId>
-                            <version>8.21</version>
+                            <version>8.29</version>
                         </dependency>
                     </dependencies>
                 </plugin>