From 0d8294291de23a547585497b3e389d8803c9dd5a Mon Sep 17 00:00:00 2001 From: "danny.song" Date: Thu, 9 Oct 2025 20:58:14 +0900 Subject: [PATCH 1/2] Fix package_classification field in OS Management Hub package data sources Fixes missing package_classification in InstalledPackageSummary and UpdatablePackageSummary data sources. Changes: - Set package_classification to INSTALLED in installed_packages - Set package_classification to UPDATABLE in updatable_packages - Add test assertions for classification values The OCI SDK adds PackageClassification only during JSON marshaling as a discriminator. Following available_packages pattern, we set the appropriate constant based on concrete type. Fixes #2457 Signed-off-by: danny.song --- ...s_management_hub_managed_instance_installed_package_test.go | 1 + ...s_management_hub_managed_instance_updatable_package_test.go | 1 + ...ment_hub_managed_instance_installed_packages_data_source.go | 3 +-- ...ment_hub_managed_instance_updatable_packages_data_source.go | 3 +-- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/integrationtest/os_management_hub_managed_instance_installed_package_test.go b/internal/integrationtest/os_management_hub_managed_instance_installed_package_test.go index 7b4ccb0d027..8586e3b5609 100644 --- a/internal/integrationtest/os_management_hub_managed_instance_installed_package_test.go +++ b/internal/integrationtest/os_management_hub_managed_instance_installed_package_test.go @@ -51,6 +51,7 @@ func TestOsManagementHubManagedInstanceInstalledPackageResource_basic(t *testing Check: acctest.ComposeAggregateTestCheckFuncWrapper( resource.TestCheckResourceAttrSet(datasourceName, "managed_instance_id"), resource.TestCheckResourceAttrSet(datasourceName, "installed_package_collection.#"), + resource.TestCheckResourceAttr(datasourceName, "installed_package_collection.0.items.0.package_classification", "INSTALLED"), ), }, }) diff --git a/internal/integrationtest/os_management_hub_managed_instance_updatable_package_test.go b/internal/integrationtest/os_management_hub_managed_instance_updatable_package_test.go index 8427061d495..6e7e04160ab 100644 --- a/internal/integrationtest/os_management_hub_managed_instance_updatable_package_test.go +++ b/internal/integrationtest/os_management_hub_managed_instance_updatable_package_test.go @@ -51,6 +51,7 @@ func TestOsManagementHubManagedInstanceUpdatablePackageResource_basic(t *testing Check: acctest.ComposeAggregateTestCheckFuncWrapper( resource.TestCheckResourceAttrSet(datasourceName, "managed_instance_id"), resource.TestCheckResourceAttrSet(datasourceName, "updatable_package_collection.#"), + resource.TestCheckResourceAttr(datasourceName, "updatable_package_collection.0.items.0.package_classification", "UPDATABLE"), ), }, }) diff --git a/internal/service/os_management_hub/os_management_hub_managed_instance_installed_packages_data_source.go b/internal/service/os_management_hub/os_management_hub_managed_instance_installed_packages_data_source.go index 9cb943e8c57..ea065673ebf 100644 --- a/internal/service/os_management_hub/os_management_hub_managed_instance_installed_packages_data_source.go +++ b/internal/service/os_management_hub/os_management_hub_managed_instance_installed_packages_data_source.go @@ -271,8 +271,7 @@ func InstalledPackageSummaryToMap(obj oci_os_management_hub.InstalledPackageSumm result["name"] = string(*obj.Name) } - // FIXME - //result["package_classification"] = string(obj.PackageClassification) + result["package_classification"] = string(oci_os_management_hub.PackageSummaryPackageClassificationInstalled) softwareSources := []interface{}{} for _, item := range obj.SoftwareSources { diff --git a/internal/service/os_management_hub/os_management_hub_managed_instance_updatable_packages_data_source.go b/internal/service/os_management_hub/os_management_hub_managed_instance_updatable_packages_data_source.go index 10a735b372e..d4eb7399426 100644 --- a/internal/service/os_management_hub/os_management_hub_managed_instance_updatable_packages_data_source.go +++ b/internal/service/os_management_hub/os_management_hub_managed_instance_updatable_packages_data_source.go @@ -305,8 +305,7 @@ func UpdatablePackageSummaryToMap(obj oci_os_management_hub.UpdatablePackageSumm result["name"] = string(*obj.Name) } - // FIXME - //result["package_classification"] = string(obj.PackageClassification) + result["package_classification"] = string(oci_os_management_hub.PackageSummaryPackageClassificationUpdatable) result["related_cves"] = obj.RelatedCves From 4978fd8c176f8124b86150d709afcca8fe376510 Mon Sep 17 00:00:00 2001 From: "danny.song" Date: Tue, 14 Oct 2025 00:06:21 +0700 Subject: [PATCH 2/2] Trigger OCA check - signatures completed Signed-off-by: danny.song