Fixed bug populating attribute MessageProperties.deliverymode after

dequeue, which is set using attribute DeqOptions.deliverymode.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -36,6 +36,8 @@ Thin Mode Changes
     ``https_proxy`` parameter can successfully perform name resolution.
 #)  Fixed bug resulting in explicit request boundaries to aid planned database
     maintenance not being sent when using connection pools with asyncio.
+#)  Fixed bug populating :attr:`MessageProperties.deliverymode` after dequeue,
+    which is set using :attr:`DeqOptions.deliverymode`.
 #)  Fixed bug resulting in ``TypeError`` when using
     :attr:`DeqOptions.correlation` for buffered delivery mode.
 #)  Fixed bug when fetching multiple consecutive null values into a data frame.

src/oracledb/impl/thin/messages/aq_array.pyx

@@ -69,6 +69,9 @@ cdef class AqArrayMessage(AqBaseMessage):
                     props_impl.msgid = msgid[j * 16:(j + 1) * 16]
             else:
                 props_impl.msgid = msgid
+                props_impl.delivery_mode = (
+                    self.deq_options_impl.delivery_mode
+                )
             buf.read_ub2(&temp16)               # extensions len
             if temp16 > 0:
                 errors._raise_err(errors.ERR_NOT_IMPLEMENTED)

src/oracledb/impl/thin/queue.pyx

@@ -74,6 +74,7 @@ cdef class BaseThinQueueImpl(BaseQueueImpl):
         message = self._conn_impl._create_message(AqDeqMessage)
         message.queue_impl = self
         message.deq_options_impl = self.deq_options_impl
+        props_impl.delivery_mode = message.deq_options_impl.delivery_mode
         message.props_impl = props_impl
         return message
 

tests/test_7800_aq_raw.py

@@ -199,6 +199,7 @@ def test_7809(self):
         results = value
         other_conn.commit()
         self.assertEqual(results, self.raw_data[0])
+        self.assertEqual(props.deliverymode, oracledb.MSG_BUFFERED)
 
     def test_7810(self):
         "7810 - test enqueue/dequeue delivery modes identical - persistent"
@@ -220,6 +221,7 @@ def test_7810(self):
         results = value
         other_conn.commit()
         self.assertEqual(results, self.raw_data[0])
+        self.assertEqual(props.deliverymode, oracledb.MSG_PERSISTENT)
 
     def test_7811(self):
         "7811 - test enqueue/dequeue delivery modes the same"

tests/test_7900_aq_raw_async.py

@@ -187,6 +187,7 @@ async def test_7909(self):
             results = value
             await other_conn.commit()
             self.assertEqual(results, self.raw_data[0])
+            self.assertEqual(props.deliverymode, oracledb.MSG_BUFFERED)
 
     async def test_7910(self):
         "7910 - test enqueue/dequeue delivery modes identical - persistent"
@@ -208,6 +209,7 @@ async def test_7910(self):
             results = value
             await other_conn.commit()
             self.assertEqual(results, self.raw_data[0])
+            self.assertEqual(props.deliverymode, oracledb.MSG_PERSISTENT)
 
     async def test_7911(self):
         "7911 - test enqueue/dequeue delivery modes the same"