Fixed bug with the deferral of type assignment when creating variables

for executemany() (#35).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -45,6 +45,9 @@ Common Changes
 #)  The compiler flag ``-arch x86_64`` no longer needs to be explicitly
     specified when building from source code on macOS (Intel x86) without
     Universal Python binaries.
+#)  Fixed bug with the deferral of type assignment when creating variables for
+    :func:`Cursor.executemany()`
+    (`issue 35 <https://github.com/oracle/python-oracledb/issues/35>`__).
 #)  Added method :func:`oracledb.is_thin_mode()` to support determining whether
     the driver is using thin mode or not
     (`issue 16 <https://github.com/oracle/python-oracledb/issues/10>`__).

src/oracledb/impl/base/cursor.pyx

@@ -335,7 +335,7 @@ cdef class BaseCursorImpl:
         num_rows = len(parameters)
         self._reset_bind_vars(num_rows)
         for i, params_row in enumerate(parameters):
-            defer_type_assignment = (i == num_rows - 1)
+            defer_type_assignment = (i < num_rows - 1)
             self._bind_values(cursor, type_handler, params_row, num_rows, i,
                               defer_type_assignment)
 

tests/test_4000_cursor_executemany.py

@@ -294,5 +294,21 @@ def test_4020_executemany_with_plsql_single_row(self):
         self.cursor.executemany("begin :1 := :2; end;", data)
         self.assertEqual(var.values, [value])
 
+    def test_4021_defer_type_assignment(self):
+        "4021 - test deferral of type assignment"
+        self.cursor.execute("truncate table TestTempTable")
+        data = [(1, None), (2, 25)]
+        self.cursor.executemany("""
+                insert into TestTempTable
+                (IntCol, NumberCol)
+                values (:1, :2)""", data)
+        self.connection.commit()
+        self.cursor.execute("""
+                select IntCol, NumberCol
+                from TestTempTable
+                order by IntCol""")
+        fetched_data = self.cursor.fetchall()
+        self.assertEqual(data, fetched_data)
+
 if __name__ == "__main__":
     test_env.run_test_cases()