Raise a more meaningful exception when attempting to use https_proxy with

protocol tcp.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -10,6 +10,13 @@ For deprecations, see :ref:`Deprecations <deprecations>`.
 oracledb 1.1.0 (TBD)
 --------------------
 
+Thin Mode Changes
++++++++++++++++++
+
+#)  When using the connection parameter `https_proxy` while using protocol
+    `tcp`, a more meaningful exception is now raised:
+    `DPY-2029: https_proxy requires use of the tcps protocol`.
+
 Thick Mode Changes
 ++++++++++++++++++
 

src/oracledb/errors.py

@@ -152,6 +152,7 @@ def _raise_from_string(exc_type: Exception, message: str) -> None:
 ERR_INVALID_POOL_CLASS = 2026
 ERR_INVALID_POOL_PARAMS = 2027
 ERR_EXPECTING_LIST_FOR_ARRAY_VAR = 2028
+ERR_HTTPS_PROXY_REQUIRES_TCPS = 2029
 
 # error numbers that result in NotSupportedError
 ERR_TIME_NOT_SUPPORTED = 3000
@@ -285,6 +286,8 @@ def _raise_from_string(exc_type: Exception, message: str) -> None:
             'to cursor.var()',
     ERR_FEATURE_NOT_SUPPORTED:
             '{feature} is only supported in python-oracledb {driver_type} mode',
+    ERR_HTTPS_PROXY_REQUIRES_TCPS:
+            'https_proxy requires use of the tcps protocol',
     ERR_INCONSISTENT_DATATYPES:
             'cannot convert from data type {input_type} to {output_type}',
     ERR_INCORRECT_VAR_ARRAYSIZE:

src/oracledb/impl/thin/connection.pyx

@@ -198,6 +198,8 @@ cdef class ThinConnImpl(BaseConnImpl):
             bint use_proxy = (address.https_proxy is not None)
             double timeout = description.tcp_connect_timeout
         if use_proxy:
+            if address.protocol != "tcps":
+                errors._raise_err(errors.ERR_HTTPS_PROXY_REQUIRES_TCPS)
             connect_info = (address.https_proxy, address.https_proxy_port)
         else:
             connect_info = (address.host, address.port)