Refactor: rename method to be more accurate.

Author: anthony-tuininga

src/oracledb/base_impl.pxd

@@ -448,8 +448,8 @@ cdef class OracleMetadata:
         ArrowSchemaImpl _schema_impl
         uint8_t _py_type_num
 
+    cdef int _create_arrow_schema(self) except -1
     cdef int _finalize_init(self) except -1
-    cdef int _set_arrow_schema(self) except -1
     cdef OracleMetadata copy(self)
     @staticmethod
     cdef OracleMetadata from_arrow_schema(ArrowSchemaImpl schema_impl)

src/oracledb/impl/base/metadata.pyx

@@ -31,32 +31,9 @@
 @cython.freelist(30)
 cdef class OracleMetadata:
 
-    cdef int _finalize_init(self) except -1:
-        """
-        Internal method that finalizes the initialization of metadata by
-        setting the buffer size, max size and default Python type (if they have
-        not already been set).
-        """
-        if self.dbtype.default_size == 0:
-            self.max_size = 0
-            self.buffer_size = self.dbtype._buffer_size_factor
-        else:
-            if self.max_size == 0:
-                self.max_size = self.dbtype.default_size
-            self.buffer_size = self.max_size * self.dbtype._buffer_size_factor
-        if self._py_type_num == 0:
-            if self.dbtype._ora_type_num != ORA_TYPE_NUM_NUMBER:
-                self._py_type_num = self.dbtype._default_py_type_num
-            else:
-                if self.scale == 0 or \
-                        (self.scale == -127 and self.precision == 0):
-                    self._py_type_num = PY_TYPE_NUM_INT
-                else:
-                    self._py_type_num = PY_TYPE_NUM_FLOAT
-
-    cdef int _set_arrow_schema(self) except -1:
+    cdef int _create_arrow_schema(self) except -1:
         """
-        Sets the Arrow schema given the metadata.
+        Creates an Arrow schema for the metadata.
         """
         cdef:
             ArrowType arrow_type, child_arrow_type = NANOARROW_TYPE_NA
@@ -131,6 +108,29 @@ cdef class OracleMetadata:
             child_arrow_type,
         )
 
+    cdef int _finalize_init(self) except -1:
+        """
+        Internal method that finalizes the initialization of metadata by
+        setting the buffer size, max size and default Python type (if they have
+        not already been set).
+        """
+        if self.dbtype.default_size == 0:
+            self.max_size = 0
+            self.buffer_size = self.dbtype._buffer_size_factor
+        else:
+            if self.max_size == 0:
+                self.max_size = self.dbtype.default_size
+            self.buffer_size = self.max_size * self.dbtype._buffer_size_factor
+        if self._py_type_num == 0:
+            if self.dbtype._ora_type_num != ORA_TYPE_NUM_NUMBER:
+                self._py_type_num = self.dbtype._default_py_type_num
+            else:
+                if self.scale == 0 or \
+                        (self.scale == -127 and self.precision == 0):
+                    self._py_type_num = PY_TYPE_NUM_INT
+                else:
+                    self._py_type_num = PY_TYPE_NUM_FLOAT
+
     cdef OracleMetadata copy(self):
         """
         Create a copy of the metadata and return it.

src/oracledb/impl/base/var.pyx

@@ -253,7 +253,7 @@ cdef class BaseVarImpl:
         user.
         """
         if self.metadata._schema_impl is None:
-            self.metadata._set_arrow_schema()
+            self.metadata._create_arrow_schema()
         self._arrow_array = ArrowArrayImpl.__new__(ArrowArrayImpl)
         self._arrow_array.populate_from_schema(self.metadata._schema_impl)