removing logs and cleaning code

Author: IshaanDesai45

commons/database/utils.go

@@ -594,13 +594,11 @@ func GetSidPdbEdition(r client.Reader, config *rest.Config, ctx context.Context,
 
 	log := ctrllog.FromContext(ctx).WithValues("GetSidbPdbEdition", req.NamespacedName)
 
-	log.Info("Finding Pods for the database " + req.Name)
 	sidbReadyPod, _, _, _, err := FindPods(r, "", "", req.Name, req.Namespace, ctx, req)
 	if err != nil {
 		log.Error(err, err.Error())
 		return "", "", "", errors.New("error while fetching sidb ready pod for sidb " + req.Name)
 	}
-	log.Info("Sidb Ready Pod name is " + sidbReadyPod.Name)
 	if sidbReadyPod.Name != "" {
 		out, err := ExecCommand(r, config, sidbReadyPod.Name, sidbReadyPod.Namespace, "",
 			ctx, req, false, "bash", "-c", GetSidPdbEditionCMD)
@@ -609,7 +607,7 @@ func GetSidPdbEdition(r client.Reader, config *rest.Config, ctx context.Context,
 			return "", "", "", errors.New("error while execing GetSidPdbEditionCMD on sidb " + req.Name)
 		}
 		log.Info(out)
-		splitstr := strings.Split(out, ",")
+		splitstr := strings.Split(strings.TrimSpace(out), ",")
 		return splitstr[0], splitstr[1], splitstr[2], nil
 	}
 

controllers/database/singleinstancedatabase_controller.go

@@ -1500,15 +1500,11 @@ func (r *SingleInstanceDatabaseReconciler) createOrReplaceSVC(ctx context.Contex
 	if m.Spec.Image.PrebuiltDB {
 		r.Log.Info("Initiliazing free database sid, pdb, edition")
 		edition := ""
-		sid, pdb, edition, err := dbcommons.GetSidPdbEdition(r, r.Config, ctx, ctrl.Request{NamespacedName: types.NamespacedName{Namespace: m.Namespace, Name: m.Name}})
+		_, _, edition, err := dbcommons.GetSidPdbEdition(r, r.Config, ctx, ctrl.Request{NamespacedName: types.NamespacedName{Namespace: m.Namespace, Name: m.Name}})
 		if err != nil {
 			return requeueY, err
 		}
-		r.Log.Info("Sid for the database is " + sid)
-		r.Log.Info("Pdb for the database is " + pdb)
-		r.Log.Info("edition for the database is " + edition)
-		r.Log.Info("editon for the dataase is " + cases.Title(language.English).String(edition))
-		m.Status.Edition = strings.TrimSpace(cases.Title(language.English).String(edition))
+		m.Status.Edition = cases.Title(language.English).String(edition)
 	}
 
 	r.Log.Info("Setting connect string statues")