document and handle InvalidPathException in history parsers (#2057)

fixes #2013

Author: Vladimir Kotal

src/org/opensolaris/opengrok/configuration/RuntimeEnvironment.java

@@ -44,6 +44,7 @@
 import java.nio.file.FileSystems;
 import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.nio.file.SimpleFileVisitor;
@@ -408,9 +409,11 @@ public String getPathRelativeToSourceRoot(File file)
      * @throws FileNotFoundException if the file is not relative to source root
      * @throws ForbiddenSymlinkException if symbolic-link checking encounters
      * an ineligible link
+     * @throws InvalidPathException if the path cannot be decoded
      */
     public String getPathRelativeToSourceRoot(File file, int stripCount)
-            throws IOException, ForbiddenSymlinkException {
+            throws IOException, ForbiddenSymlinkException, FileNotFoundException,
+            InvalidPathException {
         String sourceRoot = getSourceRootPath();
         if (sourceRoot == null) {
             throw new FileNotFoundException("Source Root Not Found");

src/org/opensolaris/opengrok/history/BazaarHistoryParser.java

@@ -29,6 +29,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.nio.file.InvalidPathException;
 import java.text.DateFormat;
 import java.text.ParseException;
 import java.util.ArrayList;
@@ -175,6 +176,8 @@ public void processStream(InputStream input) throws IOException {
                         } catch (ForbiddenSymlinkException e) {
                             LOGGER.log(Level.FINER, e.getMessage());
                             // ignored
+                        } catch (InvalidPathException e) {
+                            LOGGER.log(Level.WARNING, e.getMessage());
                         }
                     }
                     break;

src/org/opensolaris/opengrok/history/GitHistoryParser.java

@@ -30,6 +30,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.nio.file.InvalidPathException;
 import java.text.DateFormat;
 import java.text.ParseException;
 import java.util.ArrayList;
@@ -139,6 +140,8 @@ private void process(BufferedReader in) throws IOException {
                     } catch (FileNotFoundException e) { //NOPMD
                         // If the file is not located under the source root,
                         // ignore it (bug #11664).
+                    } catch (InvalidPathException e) {
+                        LOGGER.log(Level.WARNING, e.getMessage());
                     }
                 }
             }

src/org/opensolaris/opengrok/history/MercurialHistoryParser.java

@@ -29,6 +29,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.nio.file.InvalidPathException;
 import java.text.DateFormat;
 import java.text.ParseException;
 import java.util.ArrayList;
@@ -150,6 +151,8 @@ public void processStream(InputStream input) throws IOException {
                         } catch (FileNotFoundException e) { // NOPMD
                             // If the file is not located under the source root,
                             // ignore it (bug #11664).
+                        } catch (InvalidPathException e) {
+                            LOGGER.log(Level.WARNING, e.getMessage());
                         }
                     }
                 }

src/org/opensolaris/opengrok/history/MonotoneHistoryParser.java

@@ -29,6 +29,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.nio.file.InvalidPathException;
 import java.text.DateFormat;
 import java.text.ParseException;
 import java.util.ArrayList;
@@ -174,6 +175,8 @@ public void processStream(InputStream input) throws IOException {
                                 // ignore
                             } catch (FileNotFoundException e) { // NOPMD
                                 // If the file is not located under the source root, ignore it
+                            } catch (InvalidPathException e) {
+                                LOGGER.log(Level.WARNING, e.getMessage());
                             }
                         }
                     }

src/org/opensolaris/opengrok/util/PathUtils.java

@@ -26,6 +26,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.file.Files;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Paths;
 import java.util.Deque;
 import java.util.LinkedList;
@@ -94,10 +95,11 @@ public static String getRelativeToCanonical(String path, String canonical)
      * for portions of {@code path}
      * @throws ForbiddenSymlinkException if symbolic-link checking is active
      * and it encounters an ineligible link
+     * @throws InvalidPathException if path cannot be decoded
      */
     public static String getRelativeToCanonical(String path, String canonical,
         Set<String> allowedSymlinks)
-            throws IOException, ForbiddenSymlinkException {
+            throws IOException, ForbiddenSymlinkException, InvalidPathException {
 
         if (path.equals(canonical)) return "";