Merge pull request #2503 in SDK/oci-go-sdk from merge_to_github2023-08-28 to github

Releasing Version 65.48.0

Squashed commit of the following:

commit ef29e6e61fe25e4f7a4660da25b47f8e19214952
Author: oci-dex-release-bot <oci-dex-releases-bot_ww@oracle.com>
Date:   Mon Aug 28 18:51:39 2023 +0000

    Releasing version 65 48 0

Author: DEXREQ Automation

CHANGELOG.md

@@ -4,6 +4,28 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 
+## 65.48.0 - 2023-08-29
+### Added 
+- Support for creating and updating network monitors in the Application Performance Monitoring Synthetics service
+- Support for integration of GoldenGate service for replication in the Database Migration Service
+- Support for displaying resource usage information on autonomous container database and cloud autonomous vm cluster get operations in the Database service
+- Support for FastConnect Media Access Control Security (MACSec) fail open option in the Network Monitoring service
+- Support for generic bare metal types and configuration maps in compute instance platform configuration in the Compute service
+- Support for encrypted FastConnect in the Network Monitoring service
+- Support for new parameters on customer premises equipment and virtual circuit create operations in the Network Monitoring service
+- Support for virtual circuit associated tunnels in the Network Monitoring service
+- Support for additional parameters on dynamic routing gateway create and update operations in the Network Monitoring service
+- Support for assigning an IPv6 address to a compute instance during instance launch or secondary VNIC attach in the Compute service      
+ 
+### Breaking Changes
+- The models `AnalyticsCluster`, `AnalyticsClusterMemoryEstimate`, `AnalyticsClusterMemoryEstimateStatus`, `AnalyticsClusterNode`, `AnalyticsClusterSchemaMemoryEstimate`, `AnalyticsClusterSummary`, `AnalyticsClusterTableMemoryEstimate`, `UpdateAnalyticsClusterDetails`, `AddAnalyticsClusterRequest`, `DeleteAnalyticsClusterRequest`, `GenerateAnalyticsClusterMemoryEstimateRequest`, `GetAnalyticsClusterRequest`, `RestartAnalyticsClusterRequest`, `StartAnalyticsClusterRequest`, `StopAnalyticsClusterRequest`, `UpdateAnalyticsClusterRequest`, `DeleteAnalyticsClusterResponse`, `GetAnalyticsClusterMemoryEstimateResponse`, `RestartAnalyticsClusterResponse`, `StartAnalyticsClusterResponse`, `StopAnalyticsClusterResponse`, `UpdateAnalyticsClusterResponse` were removed in the MySQL Database service
+- The properties `IsAnalyticsClusterAttached` and `AnalyticsCluster` were removed from `DbSystem` and `DbSystemSummary` models in the MySQL Database service
+- The enum member `ANALYTICSCLUSTER` was removed from the enum `IsSupportedForEnum` in the models `ShapeSummary` and `ListShapesRequest` in the MySQL Database service
+- The enum members `ADD_ANALYTICS_CLUSTER`, `UPDATE_ANALYTICS_CLUSTER`, `DELETE_ANALYTICS_CLUSTER`, `START_ANALYTICS_CLUSTER`, `STOP_ANALYTICS_CLUSTER`, `RESTART_ANALYTICS_CLUSTER`, `GENERATE_ANALYTICS_CLUSTER_MEMORY_ESTIMATE` were removed from the enum `WorkRequestOperationType` in the MySQL Database service
+- The property `IsAnalyticsClusterAttached` was removed from the model `ListDbSystemsRequest` in the MySQL Database service
+- The operations `AddAnalyticsCluster`, `DeleteAnalyticsCluster`, `GenerateAnalyticsClusterMemoryEstimate`, `GetAnalyticsCluster`, `GetAnalyticsClusterMemoryEstimate`, `RestartAnalyticsCluster`, `StartAnalyticsCluster`, `StopAnalyticsCluster`, `UpdateAnalyticsCluster` were removed from the `DbSystemClient` in the MySQL Database service
+
+
 ## 65.47.2 - 2023-08-22
 ### Added 
 - Support for Compute Cloud at Customer service

Makefile

@@ -25,6 +25,10 @@ EXCLUDED_CLEAN_DIRECTORIES = objectstorage/transfer*
 
 build: lint $(TARGETS_BUILD)
 
+static-check: 
+	@staticcheck ./...
+	@echo "Success: No static check warnings"
+
 test: build $(TARGETS_TEST)
 
 test-only: $(TARGETS_TEST)

README.md

@@ -207,6 +207,36 @@ go install github.com/gofrs/flock
 ```
 go install github.com/golang/lint/golint
 ```
+- Install [staticcheck](https://github.com/dominikh/go-tools) with the command:
+```
+go install honnef.co/go/tools/cmd/staticcheck@2023.1.3
+```
+
+### Linting and Staticcheck
+Linting (performed by golint) can be done with the following command:
+
+```
+make lint
+```
+This command is also run by the make build and make test commands.
+Linting will perform a number of formatting changes across the code base.
+
+Staticcheck can be run with:
+
+```
+make static-check
+```
+Staticcheck will provide formatting warnings but will not make any changes to any files.
+You can also cause staticcheck to be run before calls to "git commit" with the pre-commit plugin.
+
+```
+pre-commit install
+```
+You can install pre-commit itself, you can use your package manager of choice, such as
+
+```
+brew install pre-commit
+```
 
 ### Build
 Building is provided by the make file at the root of the project. To build the project execute.

accessgovernancecp/accessgovernancecp_client.go

@@ -80,7 +80,7 @@ func (client *AccessGovernanceCPClient) setConfigurationProvider(configProvider
 	region, _ := configProvider.Region()
 	client.SetRegion(region)
 	if client.Host == "" {
-		return fmt.Errorf("Invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
+		return fmt.Errorf("invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
 	}
 	client.config = &configProvider
 	return nil

adm/adm_applicationdependencymanagement_client.go

@@ -80,7 +80,7 @@ func (client *ApplicationDependencyManagementClient) setConfigurationProvider(co
 	region, _ := configProvider.Region()
 	client.SetRegion(region)
 	if client.Host == "" {
-		return fmt.Errorf("Invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
+		return fmt.Errorf("invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
 	}
 	client.config = &configProvider
 	return nil

adm/create_vulnerability_audit_details.go

@@ -89,10 +89,7 @@ func (m *CreateVulnerabilityAuditDetails) UnmarshalJSON(data []byte) (e error) {
 	m.CompartmentId = model.CompartmentId
 
 	m.ApplicationDependencies = make([]ApplicationDependency, len(model.ApplicationDependencies))
-	for i, n := range model.ApplicationDependencies {
-		m.ApplicationDependencies[i] = n
-	}
-
+	copy(m.ApplicationDependencies, model.ApplicationDependencies)
 	m.Configuration = model.Configuration
 
 	m.DisplayName = model.DisplayName

adm/vulnerability_audit.go

@@ -163,10 +163,7 @@ func (m *VulnerabilityAudit) UnmarshalJSON(data []byte) (e error) {
 	m.LifecycleState = model.LifecycleState
 
 	m.Vulnerabilities = make([]Vulnerability, len(model.Vulnerabilities))
-	for i, n := range model.Vulnerabilities {
-		m.Vulnerabilities[i] = n
-	}
-
+	copy(m.Vulnerabilities, model.Vulnerabilities)
 	m.MaxObservedCvssV2Score = model.MaxObservedCvssV2Score
 
 	m.MaxObservedCvssV3Score = model.MaxObservedCvssV3Score

aianomalydetection/aianomalydetection_anomalydetection_client.go

@@ -82,7 +82,7 @@ func (client *AnomalyDetectionClient) setConfigurationProvider(configProvider co
 	region, _ := configProvider.Region()
 	client.SetRegion(region)
 	if client.Host == "" {
-		return fmt.Errorf("Invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
+		return fmt.Errorf("invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
 	}
 	client.config = &configProvider
 	return nil

aianomalydetection/detect_anomalies_details.go

@@ -31,8 +31,8 @@ type DetectAnomaliesDetails interface {
 
 type detectanomaliesdetails struct {
 	JsonData    []byte
-	ModelId     *string  `mandatory:"true" json:"modelId"`
 	Sensitivity *float32 `mandatory:"false" json:"sensitivity"`
+	ModelId     *string  `mandatory:"true" json:"modelId"`
 	RequestType string   `json:"requestType"`
 }
 
@@ -77,16 +77,16 @@ func (m *detectanomaliesdetails) UnmarshalPolymorphicJSON(data []byte) (interfac
 	}
 }
 
-//GetModelId returns ModelId
-func (m detectanomaliesdetails) GetModelId() *string {
-	return m.ModelId
-}
-
-//GetSensitivity returns Sensitivity
+// GetSensitivity returns Sensitivity
 func (m detectanomaliesdetails) GetSensitivity() *float32 {
 	return m.Sensitivity
 }
 
+// GetModelId returns ModelId
+func (m detectanomaliesdetails) GetModelId() *string {
+	return m.ModelId
+}
+
 func (m detectanomaliesdetails) String() string {
 	return common.PointerString(m)
 }

aidocument/aidocument_aiservicedocument_client.go

@@ -80,7 +80,7 @@ func (client *AIServiceDocumentClient) setConfigurationProvider(configProvider c
 	region, _ := configProvider.Region()
 	client.SetRegion(region)
 	if client.Host == "" {
-		return fmt.Errorf("Invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
+		return fmt.Errorf("invalid region or Host. Endpoint cannot be constructed without endpointServiceName or serviceEndpointTemplate for a dotted region")
 	}
 	client.config = &configProvider
 	return nil