Return proper error when invalid service name is configured in the database listener

Author: sharadraju

doc/src/release_notes.rst

@@ -23,6 +23,9 @@ Common Changes
 Thin Mode Changes
 +++++++++++++++++
 
+#)  Fixed Bug to return proper error when invalid service name is
+    configured in listener.
+
 #)  Added support for an Oracle Database 23c feature that can improve the
     performance of connection creation by reducing the number of round trips
     required to create the second and subsequent connections to the same

lib/thin/protocol/messages/protocol.js

@@ -72,12 +72,14 @@ class ProtocolMessage extends Message {
     const fdo = buf.readBytes(fdoLen);
     const ix = 6 + fdo[5] + fdo[6];
     buf.caps.nCharsetId = (fdo[ix + 3] << 8) + fdo[ix + 4];
-    this.serverCompileCaps = Buffer.from(buf.readBytesWithLength());
-    if (this.serverCompileCaps) {
+    const serverCompileCaps = buf.readBytesWithLength();
+    if (serverCompileCaps) {
+      this.serverCompileCaps = Buffer.from(serverCompileCaps);
       buf.caps.adjustForServerCompileCaps(this.serverCompileCaps);
     }
-    this.serverRunTimeCaps = Buffer.from(buf.readBytesWithLength());
-    if (this.serverRunTimeCaps) {
+    const serverRunTimeCaps = buf.readBytesWithLength();
+    if (serverRunTimeCaps) {
+      this.serverRunTimeCaps = Buffer.from(serverRunTimeCaps);
       buf.caps.adjustForServerRuntimeCaps(this.serverRunTimeCaps);
     }
   }