Minor update to the isRecoverable porperty of the Error object

Author: sharadraju

lib/errors.js

@@ -741,7 +741,7 @@ function getErr(errorNum) {
   args[0] = `${code}: ${baseText}`;
   const err = new Error(util.format(...args));
   err.code = code;
-  err.isRecoverable = false;
+  err.isRecoverable = (errorNum === ERR_CONNECTION_CLOSED);
   Error.captureStackTrace(err, getErr);
   return err;
 }

test/errorTest.js

@@ -40,13 +40,15 @@ describe('240. errorTest.js', function() {
 
   let conn;
 
-  before(async () => {
+  beforeEach(async () => {
     conn = await oracledb.getConnection(dbConfig);
   });
 
-  after(async () => {
-    if (conn)
+  afterEach(async () => {
+    if (conn) {
       await conn.close();
+      conn = null;
+    }
   });
 
   it('240.1 checks the offset value of the error', async () => {
@@ -154,4 +156,43 @@ describe('240. errorTest.js', function() {
       conn = undefined;
   }); // 240.5
 
+  it('240.6 isRecoverable property - kill session immediate', async function() {
+    // isRecoverable requires Oracle Client 12.1 or later and Oracle Database
+    // 12.1 or later.
+    // It also does not work with CMAN-TDM or DRCP.
+    const isRunnable = await testsUtil.checkPrerequisites(1200000000, 1200000000);
+    if (!isRunnable || !dbConfig.test.DBA_PRIVILEGE ||
+      dbConfig.test.drcp || dbConfig.test.isCmanTdm) this.skip();
+    const dbaConfig = {
+      user: dbConfig.test.DBA_user,
+      password: dbConfig.test.DBA_password,
+      connectionString: dbConfig.connectString,
+      privilege: oracledb.SYSDBA
+    };
+    const sysDBAConn = await oracledb.getConnection(dbaConfig);
+
+    const result = await conn.execute(
+      `select unique
+        'alter system kill session '''||sid||','||serial#||''' IMMEDIATE;'
+        from v$session_connect_info
+        where sid = sys_context('USERENV', 'SID')
+      `);
+    // get the SQL to kill the session
+    const killSql = result.rows[0][0];
+    // remove the semicolon at the end of the fetched SQL and then execute it
+    await sysDBAConn.execute(killSql.substring(0, killSql.length - 1));
+    await sysDBAConn.close();
+
+    await assert.rejects(
+      async () => await conn.commit(),
+      (err) => {
+        assert.strictEqual(err.isRecoverable, true);
+        return true;
+      }
+    );
+    // Using close() on a connection with a killed session throws
+    // an 'ORA-01012: NOT LOGGED ON' error in Thick mode
+    if (!oracledb.thin)
+      conn = undefined;
+  }); // 240.6
 });

test/list.txt

@@ -4971,6 +4971,7 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     240.3 the offset of system error is 0
     240.4 PL/SQL syntax error
     240.5 check isRecoverable property
+    240.6 isRecoverable property - kill session immediate
 
 241. dbType04.js
      241.1 JSON type check