Fix issue with getStmtInfo() function to process metadata attributes correctly

Author: sharadraju

doc/src/release_notes.rst

@@ -65,6 +65,9 @@ Thick Mode Changes
 
 #)  Internal code refactoring to optimize handling of SODA functions.
 
+#)  Fixed bug to ensure that :meth:`connection.getStmtInfo()` processes the
+    query metadata correctly.
+
 node-oracledb `v6.9.0 <https://github.com/oracle/node-oracledb/compare/v6.8.0...v6.9.0>`__ (18 Jul 2025)
 ---------------------------------------------------------------------------------------------------------
 

src/njsConnection.c

@@ -1745,7 +1745,7 @@ static bool njsConnection_getStatementInfoAsync(njsBaton *baton)
 static bool njsConnection_getStatementInfoPostAsync(njsBaton *baton,
         napi_env env, napi_value *result)
 {
-    napi_value bindNames, metadata, temp;
+    napi_value bindNames, metadata, temp, options, callingObj;
     uint32_t i;
 
     // create object for the result
@@ -1756,9 +1756,27 @@ static bool njsConnection_getStatementInfoPostAsync(njsBaton *baton,
         if (!njsVariable_initForQueryJS(baton->queryVars, baton->numQueryVars,
                 env, baton))
             return false;
-        if (!njsVariable_getMetadataMany(baton->queryVars, baton->numQueryVars,
-                env, &metadata))
+
+        // Setup the options parameter for "_setup" call in JavaScript
+        NJS_CHECK_NAPI(env, napi_create_object(env, &options))
+        NJS_CHECK_NAPI(env, napi_get_reference_value(env, baton->jsCallingObjRef,
+                &callingObj))
+        NJS_CHECK_NAPI(env, napi_set_named_property(env, options, "connection",
+                callingObj))
+        NJS_CHECK_NAPI(env, napi_create_reference(env, options, 1,
+                &baton->jsExecuteOptionsRef))
+
+        // return result set
+        if (!njsResultSet_new(baton, env,
+                (njsConnection*) baton->callingInstance, baton->dpiStmtHandle,
+                baton->queryVars, baton->numQueryVars, &temp))
             return false;
+
+        baton->dpiStmtHandle = NULL;
+        baton->queryVars = NULL;
+        baton->numQueryVars = 0;
+        NJS_CHECK_NAPI(env, napi_get_named_property(env, temp, "metaData",
+                &metadata))
         NJS_CHECK_NAPI(env, napi_set_named_property(env, *result, "metaData",
                 metadata))
     }

test/getStmtInfo.js

@@ -1,4 +1,4 @@
-/* Copyright (c) 2018, 2023, Oracle and/or its affiliates. */
+/* Copyright (c) 2018, 2025, Oracle and/or its affiliates. */
 
 /******************************************************************************
  *
@@ -494,4 +494,81 @@ describe('162. getStmtInfo.js', function() {
     const result = await conn.execute(sql, expectedRes);
     assert.deepStrictEqual(result.rows[0], expectedRes);
   });
+
+  it('162.37 Duplicate column aliases', async function() {
+    const sql = `SELECT 1 a, 'abc' a FROM dual`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, 'A');
+    assert.strictEqual(info.metaData[1].name, 'A_1');
+    const result = await conn.execute(sql);
+    assert.deepStrictEqual(result.rows[0], [1, 'abc']);
+  });
+
+  it('162.38 Simple table columns without aliases', async function() {
+    const sql = `SELECT num, content FROM ${tableName}`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, 'NUM');
+    assert.strictEqual(info.metaData[1].name, 'CONTENT');
+  });
+
+  it('162.39 Mixed aliases and table columns', async function() {
+    const sql = `SELECT num, content AS value, 'literal' AS lit FROM ${tableName}`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, 'NUM');
+    assert.strictEqual(info.metaData[1].name, 'VALUE');
+    assert.strictEqual(info.metaData[2].name, 'LIT');
+  });
+
+  it('162.40 Very long column alias names', async function() {
+    const longName = 'A'.repeat(30);
+
+    const sql = `SELECT 1 AS "${longName}", 2 AS "${longName}" FROM dual`;
+    const info = await conn.getStatementInfo(sql);
+    assert.notStrictEqual(info.metaData[0].name, info.metaData[1].name);
+  });
+
+  it('162.41 Single character duplicate aliases', async function() {
+    const sql = `SELECT 1 AS "A", 2 AS "A" FROM dual`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, 'A');
+    assert.strictEqual(info.metaData[1].name, 'A_1');
+  });
+
+  it('162.42 Numeric aliases converted to strings', async function() {
+    const sql = `SELECT 1 AS "1", 2 AS "1" FROM dual`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, '1');
+    assert.strictEqual(info.metaData[1].name, '1_1');
+  });
+
+  it('162.43 Special character aliases', async function() {
+    const sql = `SELECT 1 AS "@#$", 2 AS "@#$" FROM dual`;
+
+    const info = await conn.getStatementInfo(sql);
+    assert.strictEqual(info.metaData[0].name, '@#$');
+    assert.strictEqual(info.metaData[1].name, '@#$_1');
+  });
+
+  it('162.44 Metadata consistency between output formats - duplicate aliases', async function() {
+    const sql = `SELECT sysdate as A, sysdate as A FROM dual`;
+
+    // Test with array format
+    const infoArray = await conn.getStatementInfo(sql);
+    const resultArray = await conn.execute(sql, [], { outFormat: oracledb.OUT_FORMAT_ARRAY });
+
+    // Test with object format
+    const infoObject = await conn.getStatementInfo(sql);
+    const resultObject = await conn.execute(sql, [], { outFormat: oracledb.OUT_FORMAT_OBJECT });
+
+    assert.deepStrictEqual(infoArray.metaData, infoObject.metaData);
+    assert.deepStrictEqual(resultArray.metaData, resultObject.metaData);
+
+    assert.strictEqual(infoArray.metaData[0].name, 'A');
+    assert.strictEqual(infoArray.metaData[1].name, 'A_1');
+  });
 });

test/list.txt

@@ -4272,6 +4272,14 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     162.34 ignore literals only during bind processing
     162.35 Parse and Execute twice
     162.36 Multiple line and Multiple Asterisks
+    162.37 Duplicate column aliases
+    162.38 Simple table columns without aliases
+    162.39 Mixed aliases and table columns
+    162.40 Very long column alias names
+    162.41 Single character duplicate aliases
+    162.42 Numeric aliases converted to strings
+    162.43 Special character aliases
+    162.44 Metadata consistency between output formats - duplicate aliases
 
 163. executeMany1.js
     163.1 inserts many rows with bind by name