Support edge cases for sessionless transactions

Author: sharadraju

lib/connection.js

@@ -110,7 +110,7 @@ class Connection extends EventEmitter {
     options.connection = this;
     if (options.keepInStmtCache === undefined)
       options.keepInStmtCache = true;
-    if (options.suspendOnSuccess == undefined)
+    if (options.suspendOnSuccess === undefined)
       options.suspendOnSuccess = false;
     settings.addToOptions(options,
       "autoCommit",
@@ -720,11 +720,12 @@ class Connection extends EventEmitter {
   // If transactionId wasn't provided a random-generated transactionId will be
   // used and returned.
   //---------------------------------------------------------------------------
-  async beginSessionlessTransaction(options) {
+  async beginSessionlessTransaction(options = {}) {
+    errors.assertArgCount(arguments, 0, 1);
     errors.assertParamValue(nodbUtil.isObject(options), 1);
-    if (options.transactionId != undefined)
-      errors.assertParamValue(
-        nodbUtil.isTransactionId(options.transactionId), 1);
+    if (options.transactionId !== undefined)
+      errors.assertParamPropValue(
+        nodbUtil.isTransactionId(options.transactionId), 1, 'transactionId');
     errors.assertParamPropUnsignedIntNonZero(options, 1, 'timeout');
     errors.assertParamPropBool(options, 1, 'deferRoundTrip');
     const normalizedTransactionId =
@@ -1458,14 +1459,14 @@ class Connection extends EventEmitter {
   //
   // Resume an existing sessionlesss transaction using given transactionId
   //---------------------------------------------------------------------------
-  async resumeSessionlessTransaction(options) {
-    errors.assertParamValue(nodbUtil.isObject(options), 1);
-    errors.assertParamPropUnsignedInt(options, 1, 'timeout');
-    errors.assertParamPropBool(options, 1, 'deferRoundTrip');
-    errors.assertParamValue(
-      nodbUtil.isTransactionId(options.transactionId), 1);
+  async resumeSessionlessTransaction(transactionId, options = {}) {
+    errors.assertArgCount(arguments, 1, 2);
+    errors.assertParamValue(nodbUtil.isTransactionId(transactionId), 1);
+    errors.assertParamValue(nodbUtil.isObject(options), 2);
+    errors.assertParamPropUnsignedInt(options, 2, 'timeout');
+    errors.assertParamPropBool(options, 2, 'deferRoundTrip');
     const normalizedTransactionId =
-      nodbUtil.normalizeTransactionId(options.transactionId);
+      nodbUtil.normalizeTransactionId(transactionId);
     const {timeout = 60, deferRoundTrip = false} = options;
     await this._impl.startSessionlessTransaction(normalizedTransactionId,
       timeout, constants.TPC_BEGIN_RESUME, deferRoundTrip);
@@ -1592,6 +1593,7 @@ class Connection extends EventEmitter {
   // Suspend any active sessionless transaction immediately
   //---------------------------------------------------------------------------
   async suspendSessionlessTransaction() {
+    errors.assertArgCount(arguments, 0, 0);
     errors.assert(this._impl, errors.ERR_INVALID_CONNECTION);
     await this._impl.suspendSessionlessTransaction();
   }

lib/errors.js

@@ -500,7 +500,7 @@ messages.set(ERR_INVALID_TPC_END_FLAGS,                 // NJS-151
 messages.set(ERR_UNKNOWN_TRANSACTION_STATE,             // NJS-152
   'internal error: unknown transaction state {state} in Two Phase Commit');
 messages.set(ERR_INVALID_TRANSACTION_SIZE,              // NJS-153
-  'size of the transaction ID is %d and cannot exceed 64');
+  'size of the transaction ID must be non-zero and must not exceed 64. Its current size is %d.');
 messages.set(ERR_INVALID_BRANCH_SIZE,                   // NJS-154
   'size of the branch ID is %d and cannot exceed 64');
 messages.set(ERR_OPERATION_NOT_SUPPORTED_ON_BFILE,      // NJS-155

lib/util.js

@@ -473,13 +473,13 @@ function isTransactionId(value) {
 //---------------------------------------------------------------------------
 function normalizeTransactionId(value) {
   let normalizedTransactionId = value;
-  if (!normalizedTransactionId)
+  if (normalizedTransactionId === undefined)
     normalizedTransactionId = crypto.randomUUID();
   if (typeof normalizedTransactionId === 'string') {
     normalizedTransactionId = Buffer.from(normalizedTransactionId);
-    if (normalizedTransactionId.length > 64)
-      errors.throwErr(errors.ERR_INVALID_TRANSACTION_SIZE,
-        normalizedTransactionId.length);
+    const len = normalizedTransactionId.length;
+    if ((len === 0) || (len > 64))
+      errors.throwErr(errors.ERR_INVALID_TRANSACTION_SIZE, len);
   }
   return normalizedTransactionId;
 }

test/list.txt

@@ -6306,21 +6306,42 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     315.1 Testing maxLifetimeSession on conn release
     315.2 Testing maxLifetimeSession on conn acquire
   316. sessionless.js
-    316.1 Sessionless Functions
-      316.1.1 Test server procedures
-      316.1.2 Test Client APIs
-      316.1.3 transaction timeout behavior
-      316.1.4 error handling during sessionless transaction
-      316.1.5 multiple concurrent sessionless transactions
-      316.1.6 different GTRID formats
-      316.1.7 with savepoints
-      316.1.8 sessionless transactions with connection pool
-      316.1.9 mixing server and client methods
-      316.1.10 resuming without suspnding current txn
-      316.1.11 suspendOnSuccess error
-      316.1.12 sessionless transaction with large operations
-      316.1.13 transaction behavior with some DDL operation
-      316.1.14 zero timeout behavior
-      316.1.15 retrieve GTRID of active sessionless transaction
-      316.1.16 Checking behaviour with XA transactions
-      316.1.17 Behaviour with local transactions
+    316.1 Server and Client API Integration
+        316.1.1 test server procedures
+        316.1.2 mixing server and client methods
+        316.1.3 suspendOnSuccess behaviour
+    316.2 Basic Client API Operations
+        316.2.1 test client APIs
+        316.2.2 resuming without suspending current txn
+        316.2.3 retrieve transactionId of active sessionless transaction
+        316.2.4 suspend without active sessionless transaction
+    316.3 Multiple Concurrent Transactions
+        316.3.1 multiple concurrent sessionless transactions
+        316.3.2 duplicate transactionId across different connections
+        316.3.3 nested transaction operations
+        316.3.4 auto-generated transactionId uniqueness
+    316.4 Connection Pool Operations
+        316.4.1 sessionless transactions with connection pool
+    316.5 Timeout and Error Handling
+        316.5.1 transaction timeout behavior
+        316.5.2 error handling during sessionless transaction
+        316.5.3 zero timeout behavior
+        316.5.4 resume non-existent transactionId
+        316.5.5 maximum timeout value behavior
+        316.5.6 negative timeout values
+    316.6 Transaction ID Validation
+        316.6.1 different transactionId formats
+        316.6.2 empty transactionId behavior
+        316.6.3 unicode characters in transactionId
+        316.6.4 unicode transaction ID with special Oracle characters
+        316.6.5 white-space only transactionId
+    316.7 Advanced Database Operations
+        316.7.1 with savepoints
+        316.7.2 sessionless transaction with large operations
+        316.7.3 transaction behavior with some DDL operation
+        316.7.4 transaction with very long string data
+        316.7.5 suspendOnSuccess with executeMany
+        316.7.6 suspendOnSuccess with executeMany and bindDefs
+    316.8 other Transaction Types
+        316.8.1 checking behaviour with XA transactions
+        316.8.2 checking behaviour with local transactions