Improve Lob bind test

Author: Christopher Jones

test/list.txt

@@ -1289,7 +1289,6 @@ Overview of node-oracledb functional tests
         72.2.4 Negative - not providing first parameter
         72.2.5 promise test of createLob()
         72.2.6 call lob.close() multiple times sequentially
-        72.2.7 BIND_INOUT, PL/SQL, needs to close out lob explicitly
 
 73. poolPing.js
     73.1 the default value of poolPingInterval is 60

test/lobBind2.js

@@ -894,115 +894,6 @@ describe("72. lobBind2.js", function() {
 
     }); // 72.2.6
 
-    it("72.2.7 BIND_INOUT, PL/SQL, needs to close out lob explicitly", function(done) {
-
-      var seq = 7, outLobId = 77;
-      var outFileName = './test/tree.jpg';
-      var proc = "CREATE OR REPLACE PROCEDURE nodb_proc_blob_inout1 \n" +
-                 "  (p_num IN NUMBER, p_from IN NUMBER, p_inout IN OUT BLOB) \n" +
-                 "AS \n" +
-                 "BEGIN \n" +
-                 "    insert into nodb_tab_blob72 (id, content) values (p_num, p_inout); \n" +
-                 "    select content into p_inout from nodb_tab_blob72 where id = p_from; \n" +
-                 "END nodb_proc_blob_inout1;";
-
-      var prepareOutBlob = function(callback) {
-
-        var buf = fs.readFileSync(outFileName);
-        connection.execute(
-          "INSERT INTO nodb_tab_blob72 (id, content) VALUES (:id, :b)",
-          { id: outLobId, b: buf },
-          { autoCommit: true },
-          function(err, result) {
-            should.not.exist(err);
-            (result.rowsAffected).should.be.exactly(1);
-            return callback();
-          }
-        );
-
-      };
-
-      var dotest = function(callback) {
-
-        connection.createLob(oracledb.BLOB, function(err, lob) {
-          should.not.exist(err);
-
-          lob.on('error', function(err) {
-            should.not.exist(err, "lob.on 'error' event.");
-          });
-
-          lob.on('finish', function() {
-
-            connection.execute(
-              "begin nodb_proc_blob_inout1(:id, :oid, :io); end;",
-              {
-                id: seq,
-                oid: outLobId,
-                io: { type: oracledb.BLOB, dir: oracledb.BIND_INOUT, val: lob }
-              },
-              { autoCommit: true },
-              function(err, result) {
-                should.not.exist(err);
-                var lobout = result.outBinds.io;
-
-                lobout.on('close', function(err) {
-                  should.not.exist(err);
-
-                  return callback();
-                });
-
-                lobout.on('error', function(err) {
-                  should.not.exist(err, "lob.on 'error' event.");
-                });
-
-                var blobData;
-                lobout.on('data', function(chunk) {
-                  blobData += chunk;
-                });
-
-                lobout.on('finish', function() {
-
-                  var buf = fs.readFileSync(outFileName);
-                  (blobData).should.eql(buf);
-
-                  lobout.close(function(err) {
-                    should.not.exist(err);
-                  });
-                });
-
-              }
-            );
-
-          }); // finish event of lob
-
-          var inStream = fs.createReadStream(jpgFileName);
-          inStream.pipe(lob);
-
-          inStream.on('error', function(err) {
-            should.not.exist(err, "inStream.on 'error' event.");
-          });
-
-        });
-
-      };
-
-      async.series([
-        function(cb) {
-          executeSQL(proc, cb);
-        },
-        prepareOutBlob,
-        dotest,
-        function(cb) {
-          verifyBlobValue(seq, jpgFileName, cb);
-        },
-        function(cb) {
-          var sql = "DROP PROCEDURE nodb_proc_blob_inout1";
-          executeSQL(sql, cb);
-        }
-      ], done);
-
-    }); // 72.2.7
-
   }); // 72.2
 
-});
+});