Fixed bug that causes pooled connections to wait forever in certain heavy workload scenarios (Issue #1700)

sharadraju · sharadraju · commit 2c18432b9952 · 2024-11-13T22:38:17.000+05:30
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -50,6 +50,11 @@ Common Changes
 Thin Mode Changes
 +++++++++++++++++
 
+#)  Fixed bug that causes pooled connections to wait forever in certain heavy
+    workload scenarios.
+    See `Issue #1700 <https://github.com/oracle/node-oracledb/issues/
+    1700>`__.
+
 #)  Fixed cursor leak for dbobject binds using :meth:`connection.getDbObjectClass()`.
     See `Issue #1694 <https://github.com/oracle/node-oracledb/issues/
     1694>`__.
diff --git a/lib/pool.js b/lib/pool.js
@@ -423,7 +423,7 @@ class Pool extends EventEmitter {
       throw err;
     }
 
-    if (this._connectionsOut >= poolMax ||
+    while (this._connectionsOut >= poolMax ||
         this.status === constants.POOL_STATUS_RECONFIGURING) {
 
       // when the queue is huge, throw error early without waiting for queue

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ class Pool extends EventEmitter {`
`423`	`423`	`throw err;`
`424`	`424`	`}`
`425`	`425`
`426`		`- if (this._connectionsOut >= poolMax \|\|`
	`426`	`+ while (this._connectionsOut >= poolMax \|\|`
`427`	`427`	`this.status === constants.POOL_STATUS_RECONFIGURING) {`
`428`	`428`
`429`	`429`	`// when the queue is huge, throw error early without waiting for queue`