Skip to content

Commit 85b8eaa

Browse files
KanjiMonsterharshimogalapalli
authored andcommitted
net: dsa: b53: do not enable EEE on bcm63xx
commit 1237c2d upstream. BCM63xx internal switches do not support EEE, but provide multiple RGMII ports where external PHYs may be connected. If one of these PHYs are EEE capable, we may try to enable EEE for the MACs, which then hangs the system on access of the (non-existent) EEE registers. Fix this by checking if the switch actually supports EEE before attempting to configure it. Fixes: 22256b0 ("net: dsa: b53: Move EEE functions to b53") Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Tested-by: Álvaro Fernández Rojas <noltari@gmail.com> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Link: https://patch.msgid.link/20250602193953.1010487-2-jonas.gorski@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 3fbe3f4c57fda09f32e13fa05f53a0cc6f500619) Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
1 parent 9e46b6b commit 85b8eaa

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2378,6 +2378,9 @@ int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy)
23782378
{
23792379
int ret;
23802380

2381+
if (!b53_support_eee(ds, port))
2382+
return 0;
2383+
23812384
ret = phy_init_eee(phy, false);
23822385
if (ret)
23832386
return 0;
@@ -2392,7 +2395,7 @@ bool b53_support_eee(struct dsa_switch *ds, int port)
23922395
{
23932396
struct b53_device *dev = ds->priv;
23942397

2395-
return !is5325(dev) && !is5365(dev);
2398+
return !is5325(dev) && !is5365(dev) && !is63xx(dev);
23962399
}
23972400
EXPORT_SYMBOL(b53_support_eee);
23982401

0 commit comments

Comments
 (0)