addressing review comments

Author: naren2605

vscode/src/localiser.ts

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2023-2024, Oracle and/or its affiliates.
+  Copyright (c) 2023-2025, Oracle and/or its affiliates.
 
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -21,9 +21,10 @@ import * as fs from 'fs';
 import { extConstants } from './constants';
 import { FileUtils } from './utils';
 import { LOGGER } from './logger';
+import path = require('path');
 
 const DEFAULT_LANGUAGE = "en";
-const DEFAULT_BUNDLE_FILE = `l10n/bundle.l10n.${DEFAULT_LANGUAGE}.json`;
+const DEFAULT_BUNDLE_FILE = path.join("l10n", `bundle.l10n.${DEFAULT_LANGUAGE}.json`);
 const _format2Regexp = /{([^}]+)}/g;
 
 export interface l10n {
@@ -35,8 +36,8 @@ export interface l10n {
 class l10Wrapper implements l10n {
   private defaultl10nMap: any;
   constructor(extensionId: string, defaultBundlePath: string) {
-    let extnPath = vscode.extensions.getExtension(extensionId)?.extensionPath;
-    let defaultBundleAbsoluteFsPath = FileUtils.toUri(`${extnPath}/${defaultBundlePath}`).fsPath;
+    let extnPath = vscode.extensions.getExtension(extensionId)!!.extensionPath;
+    let defaultBundleAbsoluteFsPath = FileUtils.toUri(path.join(extnPath,defaultBundlePath)).fsPath;
     let logAndThrowError = (message: string, err: unknown) => {
       let errMsg = "";
       if (err instanceof Error) {

vscode/src/test/unit/general/localetest.unit.test.ts renamed to vscode/src/test/unit/general/localiser.unit.test.ts

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2023-2024, Oracle and/or its affiliates.
+  Copyright (c) 2023-2025, Oracle and/or its affiliates.
 
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ const replaceImportsWithMocks = (mocks: any) => {
 
         if (request === 'vscode') {
             return mocks.vscode;
-        } else if (request.includes('localiser') && !(_parent?.filename?.includes("localetest.unit.test.ts") || _parent?.filename?.includes("localetest.unit.test.js")) ) {
+        } else if (request.includes('localiser') && !(_parent?.filename?.includes("localiser.unit.test.ts") || _parent?.filename?.includes("localiser.unit.test.js")) ) {
             return mocks.localiser;
         }
 

vscode/src/test/unit/mocks/init.ts

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2023-2024, Oracle and/or its affiliates.
+  Copyright (c) 2023-2025, Oracle and/or its affiliates.
 
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -22,7 +22,7 @@ import { mockedEnums } from './vscodeHostedTypes';
 import { NotebookCellOutputItem } from './notebookCellOutputItem';
 import { mock,instance } from "ts-mockito";
 type VSCode = typeof vscode;
-const mockedVSCode: Partial<VSCode> & { mockedExtns?:typeof vscode.extensions,mockedL10n?:typeof vscode.l10n} = {};
+const mockedVSCode: Partial<VSCode> & { mockedExtns?: typeof vscode.extensions, mockedL10n?: typeof vscode.l10n } = {};
 
 const mockedVscodeClassesAndTypes = () => {
     mockedVSCode.Uri = URI as any;

vscode/src/test/unit/mocks/vscode/mockVscode.ts

@@ -19,9 +19,9 @@ import { mock, when, anyString, anyOfClass, anything, instance } from "ts-mockit
 
 type VSCode = typeof vscode;
 let mockedEnv: typeof vscode.env;
-export const mockEnvNamespace = (mockedVSCode: Partial<VSCode> & { mockedEnv?:typeof vscode.env}) => {
+export const mockEnvNamespace = (mockedVSCode: Partial<VSCode> & { mockedEnv?: typeof vscode.env }) => {
     mockedEnv = mock<typeof vscode.env>();
-    mockedVSCode.mockedEnv=mockedEnv;
+    mockedVSCode.mockedEnv = mockedEnv;
     mockedVSCode.env = instance(mockedEnv);
     mockTelemetryFields();
 }