Fix new perf warnings

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ImpModuleBuiltins.java

@@ -389,9 +389,10 @@ static int doOther(@SuppressWarnings("unused") Object extensionModule) {
         }
     }
 
-    @Builtin(name = "is_builtin", minNumOfPositionalArgs = 1)
+    @Builtin(name = "is_builtin", minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 1, parameterNames = {"name"})
+    @ArgumentClinic(name = "name", conversion = ClinicConversion.TString)
     @GenerateNodeFactory
-    public abstract static class IsBuiltin extends PythonBuiltinNode {
+    public abstract static class IsBuiltin extends PythonUnaryClinicBuiltinNode {
 
         @Specialization
         @TruffleBoundary
@@ -404,21 +405,9 @@ public int run(TruffleString name) {
             }
         }
 
-        @Specialization
-        @TruffleBoundary
-        public int run(PString name,
-                        @Bind Node inliningTarget,
-                        @Cached CastToTruffleStringNode toString) {
-            try {
-                return run(toString.execute(inliningTarget, name));
-            } catch (CannotCastException e) {
-                throw CompilerDirectives.shouldNotReachHere(e);
-            }
-        }
-
-        @Fallback
-        public int run(@SuppressWarnings("unused") Object noName) {
-            return 0;
+        @Override
+        protected ArgumentClinicProvider getArgumentClinic() {
+            return ImpModuleBuiltinsClinicProviders.IsBuiltinClinicProviderGen.INSTANCE;
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyObjectSetAttrO.java

@@ -43,17 +43,14 @@
 import static com.oracle.graal.python.nodes.ErrorMessages.ATTR_NAME_MUST_BE_STRING;
 
 import com.oracle.graal.python.builtins.PythonBuiltinClassType;
-import com.oracle.graal.python.builtins.objects.str.PString;
 import com.oracle.graal.python.builtins.objects.type.TpSlots;
 import com.oracle.graal.python.builtins.objects.type.TpSlots.GetObjectSlotsNode;
 import com.oracle.graal.python.builtins.objects.type.slots.TpSlotSetAttr.CallSlotSetAttrONode;
 import com.oracle.graal.python.nodes.PNodeWithContext;
 import com.oracle.graal.python.nodes.PRaiseNode;
-import com.oracle.graal.python.nodes.util.CastToTruffleStringNode;
 import com.oracle.truffle.api.HostCompilerDirectives.InliningCutoff;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
-import com.oracle.truffle.api.dsl.Cached.Shared;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateCached;
 import com.oracle.truffle.api.dsl.GenerateInline;
@@ -87,17 +84,10 @@ public final void executeCached(VirtualFrame frame, Object object, Object key, O
 
     @Specialization
     static void doIt(Frame frame, Node inliningTarget, Object self, TruffleString name, Object value,
-                    @Shared @Cached PyObjectSetAttr setAttr) {
+                    @Cached PyObjectSetAttr setAttr) {
         setAttr.execute(frame, inliningTarget, self, name, value);
     }
 
-    @Specialization(guards = "isBuiltinPString(name)")
-    static void doIt(Frame frame, Node inliningTarget, Object self, PString name, Object value,
-                    @Cached CastToTruffleStringNode castNode,
-                    @Shared @Cached PyObjectSetAttr setAttr) {
-        setAttr.execute(frame, inliningTarget, self, castNode.castKnownString(inliningTarget, name), value);
-    }
-
     @Fallback
     @InliningCutoff
     static void doIt(Frame frame, Object self, Object nameObj, Object value,