Remove uneccessary user arguments bounds checks

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/PArguments.java

@@ -30,11 +30,9 @@
 import com.oracle.graal.python.builtins.objects.object.PythonObject;
 import com.oracle.graal.python.runtime.PythonOptions;
 import com.oracle.graal.python.runtime.exception.PException;
-import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.exception.AbstractTruffleException;
 import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.MaterializedFrame;
-import com.oracle.truffle.api.frame.VirtualFrame;
 
 //@formatter:off
 /**
@@ -218,26 +216,13 @@ public static void setArgument(Object[] arguments, int index, Object value) {
     }
 
     public static Object getArgument(Object[] arguments, int index) {
-        int argIdx = USER_ARGUMENTS_OFFSET + index;
-        if (argIdx < arguments.length) {
-            return arguments[argIdx];
-        } else {
-            return null;
-        }
+        return arguments[USER_ARGUMENTS_OFFSET + index];
     }
 
     public static Object getArgument(Frame frame, int index) {
         return getArgument(frame.getArguments(), index);
     }
 
-    public static int getUserArgumentLength(VirtualFrame frame) {
-        return frame.getArguments().length - USER_ARGUMENTS_OFFSET;
-    }
-
-    public static int getUserArgumentLength(Object[] arguments) {
-        return arguments.length - USER_ARGUMENTS_OFFSET;
-    }
-
     public static MaterializedFrame getGeneratorFrame(Object[] arguments) {
         assert !PythonOptions.ENABLE_BYTECODE_DSL_INTERPRETER;
         return (MaterializedFrame) arguments[INDEX_GENERATOR_FRAME];
@@ -288,9 +273,6 @@ public static void synchronizeArgs(Frame frameToMaterialize, PFrame escapedFrame
         setGlobals(copiedArgs, getGlobals(arguments));
         setClosure(copiedArgs, getClosure(arguments));
 
-        // copy all user arguments
-        PythonUtils.arraycopy(arguments, USER_ARGUMENTS_OFFSET, copiedArgs, USER_ARGUMENTS_OFFSET, getUserArgumentLength(arguments));
-
         escapedFrame.setArguments(copiedArgs);
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/ReadIndexedArgumentNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2021, Oracle and/or its affiliates.
+ * Copyright (c) 2017, 2025, Oracle and/or its affiliates.
  * Copyright (c) 2013, Regents of the University of California
  *
  * All rights reserved.
@@ -25,11 +25,9 @@
  */
 package com.oracle.graal.python.nodes.argument;
 
-import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.function.PArguments;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.nodes.InvalidAssumptionException;
 import com.oracle.truffle.api.profiles.ValueProfile;
 
 public abstract class ReadIndexedArgumentNode extends ReadArgumentNode {
@@ -44,22 +42,9 @@ public static ReadIndexedArgumentNode create(int idx) {
         return ReadIndexedArgumentNodeGen.create(idx);
     }
 
-    @Specialization(rewriteOn = InvalidAssumptionException.class)
-    Object readArg(VirtualFrame frame) throws InvalidAssumptionException {
-        Object argumentAt = PArguments.getArgument(frame, index);
-        if (argumentAt == null) {
-            throw new InvalidAssumptionException();
-        }
-        return profile.profile(argumentAt);
-    }
-
-    @Specialization(replaces = "readArg")
-    Object readArgOffBounds(VirtualFrame frame) {
-        Object argumentAt = PArguments.getArgument(frame, index);
-        if (argumentAt == null) {
-            return PNone.NO_VALUE;
-        }
-        return profile.profile(argumentAt);
+    @Specialization
+    Object readArg(VirtualFrame frame) {
+        return profile.profile(PArguments.getArgument(frame, index));
     }
 
     public int getIndex() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/builtins/WrapperDescrCall.java

@@ -71,12 +71,7 @@ public WrapperDescrCall(BuiltinCallNode func, String name, PythonBuiltinClassTyp
 
     @Override
     public Object execute(VirtualFrame frame) {
-        Object[] args = frame.getArguments();
-        if (PArguments.getUserArgumentLength(args) <= 0) {
-            CompilerDirectives.transferToInterpreterAndInvalidate();
-            throw PRaiseNode.raiseStatic(this, PythonBuiltinClassType.TypeError, ErrorMessages.DESCRIPTOR_NEED_OBJ, name, "_");
-        }
-        Object self = PArguments.getArgument(args, 0);
+        Object self = PArguments.getArgument(frame, 0);
         Object selfClass = getClassNode.executeCached(self);
         if (selfClass != type && !isSubtypeNode.execute(selfClass, type)) {
             CompilerDirectives.transferToInterpreterAndInvalidate();