add test to guard the feature is not available by default, or with the flag set to false

Author: wirthi

graal-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/builtins/NewSetMethodsTest.java

@@ -61,6 +61,25 @@ private static Context getNewSetMethodsContext() {
         return JSTest.newContextBuilder().option(JSContextOptions.NEW_SET_METHODS_NAME, "true").build();
     }
 
+    @Test
+    public void testNotAvailableByDefault() {
+        String code = String.format("var set1 = %s; set1.union(set1)", createSetString(1, 2, 3, 4));
+
+        try (Context context = JSTest.newContextBuilder().build()) {
+            context.eval(JavaScriptLanguage.ID, code);
+            Assert.fail("Should fail with default flags.");
+        } catch (PolyglotException ex) {
+            assertTrue(ex.getMessage().contains("union is not a function"));
+        }
+
+        try (Context context = JSTest.newContextBuilder().option(JSContextOptions.NEW_SET_METHODS_NAME, "false").build()) {
+            context.eval(JavaScriptLanguage.ID, code);
+            Assert.fail("Should fail with js.new-set-methods=false");
+        } catch (PolyglotException ex) {
+            assertTrue(ex.getMessage().contains("union is not a function"));
+        }
+    }
+
     @Test
     public void testUnion() {
         try (Context context = getNewSetMethodsContext()) {

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/SetPrototypeBuiltins.java

@@ -321,7 +321,7 @@ protected JSSetNewOperation(JSContext context, JSBuiltin builtin) {
         }
 
         protected Object addEntryFromIterable(Object target, Object iterable, Object adder) {
-            if (!JSRuntime.isCallable(adder)) {
+            if (!isCallable(adder)) {
                 adderError.enter();
                 throw Errors.createTypeErrorCallableExpected();
             }

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSContextOptions.java

@@ -63,7 +63,6 @@
 import com.oracle.truffle.api.Option;
 import com.oracle.truffle.api.nodes.InvalidAssumptionException;
 import com.oracle.truffle.api.utilities.CyclicAssumption;
-import com.oracle.truffle.js.runtime.JSContextOptions.UnhandledRejectionsTrackingMode;
 
 public final class JSContextOptions {
 

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSSet.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0