Skip to content

Commit 7ef89aa

Browse files
committed
[GR-30943] Removing the definition of the obsolete FinalizationGroup.
PullRequest: js/1989
2 parents 351bf45 + 343fbf5 commit 7ef89aa

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

graal-nodejs/lib/internal/bootstrap/node.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,6 @@ setupProcessObject();
5555
if (typeof Packages !== 'undefined') {
5656
Packages[Symbol.toStringTag] = 'Packages'; // breaking isRhino check of acorn package
5757
}
58-
if (typeof FinalizationRegistry !== 'undefined') {
59-
Object.defineProperty(globalThis, 'FinalizationGroup', {
60-
value: FinalizationRegistry,
61-
enumerable: false,
62-
writable: true,
63-
configurable: true
64-
});
65-
}
6658
// graal-node.js patch end
6759

6860
setupGlobalProxy();

graal-nodejs/test/graal/unit/buffer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ describe('Buffer.utf8Write', function() {
9393
it('length is zero', function() {
9494
assert.strictEqual(Buffer.alloc(0).utf8Write.length, 0);
9595
});
96-
if (typeof java !== undefined) {
96+
if (typeof java !== "undefined") {
9797
it('should accept interop buffer', function() {
9898
var byteLength = 8;
9999
var offset = 4;
@@ -159,7 +159,7 @@ describe('Buffer.utf8Slice', function() {
159159
it('length is zero', function() {
160160
assert.strictEqual(Buffer.alloc(0).utf8Slice.length, 0);
161161
});
162-
if (typeof java !== undefined) {
162+
if (typeof java !== "undefined") {
163163
it('should accept interop buffer', function() {
164164
var javaBuffer = java.nio.ByteBuffer.allocate(8);
165165
javaBuffer.put(3, 'f'.codePointAt(0));

graal-nodejs/test/graal/unit/other.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,7 @@ describe('Other', function () {
9191
// should not fail (fails when Node.js is built without intl support)
9292
new util.TextDecoder('utf-8', { fatal: true });
9393
});
94+
it('should not define FinalizationGroup', function () {
95+
assert.strictEqual(global.FinalizationGroup, undefined);
96+
});
9497
});

graal-nodejs/test/graal/unit/waitAsync.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141

4242
const assert = require('assert');
4343

44-
describe('waitAsync', function () {
44+
describe.skipOnNode('waitAsync', function () {
4545
it('should work', function() {
4646
this.timeout(20000);
4747
var child_process = require('child_process');

0 commit comments

Comments
 (0)