Skip to content

Commit e860494

Browse files
marwan-hallaouizapster
authored andcommitted
compiler : fix JVMCIVersionCheck --as-tag output
1 parent ab607f1 commit e860494

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/hotspot/test/JVMCIVersionCheckMain.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ public void testMinVersionAsTag() {
7979
String out = runMainCaptureOut("--min-version", "--as-tag");
8080
Assert.assertNotNull(out);
8181
Assert.assertFalse(out.contains("No minimum JVMCI version specified for JDK version"));
82-
// check that the output is a valid version
83-
Runtime.Version.parse(out.strip());
82+
Assert.assertTrue(out.startsWith("jvmci-"));
8483
}
8584

8685
@Test(expected = IllegalArgumentException.class)

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/JVMCIVersionCheck.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,17 +246,17 @@ public int hashCode() {
246246
return Objects.hashCode(this.jdkVersion) ^ Objects.hashCode(this.releaseName) ^ this.jvmciBuild;
247247
}
248248

249-
public static final String AS_TAG_FORMAT_RELEASE_NAME = "%s-jvmci-%s-b%02d";
249+
public static final String AS_TAG_FORMAT_RELEASE_NAME = "jvmci-%s-b%02d";
250+
public static final String TO_STRING_FORMAT_RELEASE_NAME = "%s-jvmci-%s-b%02d";
250251
public static final String AS_TAG_FORMAT_22_AND_LATER = "%s-jvmci-b%02d";
251-
public static final String AS_TAG_FORMAT_21_AND_EARLIER = "jvmci-%d.%d-b%02d";
252252

253253
@Override
254254
public String toString() {
255255
if (isOpenJDK()) {
256256
return jdkVersion.toString();
257257
}
258258
if (releaseName != null) {
259-
return String.format(AS_TAG_FORMAT_RELEASE_NAME, jdkVersion, releaseName, jvmciBuild);
259+
return String.format(TO_STRING_FORMAT_RELEASE_NAME, jdkVersion, releaseName, jvmciBuild);
260260
} else {
261261
return String.format(AS_TAG_FORMAT_22_AND_LATER, jdkVersion, jvmciBuild);
262262
}
@@ -265,7 +265,15 @@ public String toString() {
265265
public String printFormat(PrintFormat format) {
266266
return switch (format) {
267267
case TUPLE -> String.format("%s,%s,%d", jdkVersion, releaseName, jvmciBuild);
268-
case AS_TAG -> toString();
268+
case AS_TAG -> {
269+
if (isOpenJDK()) {
270+
yield jdkVersion.toString();
271+
} else if (releaseName != null) {
272+
yield String.format(AS_TAG_FORMAT_RELEASE_NAME, releaseName, jvmciBuild);
273+
} else {
274+
yield String.format(AS_TAG_FORMAT_22_AND_LATER, jdkVersion, jvmciBuild);
275+
}
276+
}
269277
};
270278
}
271279

0 commit comments

Comments
 (0)