[GR-67613] Transient IllegalArgumentException: Unknown language or instrument id com_oracle_truffle_api_test_polyglot_polyglotgctest_valuegclanguage.

PullRequest: graal/22406

Author: tzezula

sdk/CHANGELOG.md

@@ -9,6 +9,7 @@ This changelog summarizes major changes between GraalVM SDK versions. The main f
 * GR-66817 Make `--polyglot` the default for language launchers, so there is no need to specify it anymore to use other languages in standalones. As a result, `AbstractLanguageLauncher#getDefaultLanguages()` and `Launcher#canPolyglot()` have been deprecated.
 * GR-65404 Remove `PolyglotLauncher` as it is no longer used.
 * GR-68613: JavaScript polyglot isolate now includes support for the WebAssembly (Wasm) language.
+* GR-69590: Closing a garbage-collected engine or context now logs only the first failure by default. To log all failures, use `engine.CloseOnGCFailureAction.PrintAll`.
 
 ## Version 25.0.0
 * GR-60636 Truffle now stops compiling when the code cache fills up on HotSpot. A warning is printed when that happens.

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/TruffleLogger.java

@@ -1046,8 +1046,8 @@ private TruffleLogger getOrCreateLogger(final String loggerName) {
         }
 
         private TruffleLogger getOrCreateLogger(final String id, final String loggerName) {
-            if (!LanguageAccessor.ENGINE.isKnownLoggerId(id)) {
-                throw new IllegalArgumentException("Unknown language or instrument id " + id + ", known ids: " + String.join(", ", LanguageAccessor.ENGINE.getKnownLoggerIds()));
+            if (!LanguageAccessor.ENGINE.isKnownLoggerId(loggerCache, id)) {
+                throw new IllegalArgumentException("Unknown language or instrument id " + id + ", known ids: " + String.join(", ", LanguageAccessor.ENGINE.getKnownLoggerIds(loggerCache)));
             }
             final String globalLoggerId = loggerName == null || loggerName.isEmpty() ? id : id + '.' + loggerName;
             return getOrCreateLogger(globalLoggerId);

truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/impl/Accessor.java

@@ -554,9 +554,9 @@ public abstract Thread createThread(Object polyglotLanguageContext, Runnable run
 
         public abstract LogRecord createLogRecord(Object loggerCache, Level level, String loggerName, String message, String className, String methodName, Object[] parameters, Throwable thrown);
 
-        public abstract boolean isKnownLoggerId(String id);
+        public abstract boolean isKnownLoggerId(Object loggerCache, String id);
 
-        public abstract Collection<String> getKnownLoggerIds();
+        public abstract Collection<String> getKnownLoggerIds(Object loggerCache);
 
         public abstract boolean isContextBoundLogger(Object loggerCache);
 

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/EngineAccessor.java

@@ -1435,16 +1435,37 @@ public LogRecord createLogRecord(Object loggerCache, Level level, String loggerN
         }
 
         @Override
-        public boolean isKnownLoggerId(String id) {
-            return PolyglotLoggers.getInternalIds().contains(id) || LanguageCache.languages().containsKey(id) || InstrumentCache.load().containsKey(id);
+        public boolean isKnownLoggerId(Object loggerCache, String id) {
+            if (PolyglotLoggers.getInternalIds().contains(id)) {
+                return true;
+            }
+            if (loggerCache == PolyglotLoggers.LoggerCache.DEFAULT) {
+                /*
+                 * TruffleLogger#getLogger() is invoked from a static initializer, no vmObject
+                 * anchor is available at this point.
+                 */
+                return LanguageCache.languages().containsKey(id) || InstrumentCache.load().containsKey(id);
+            } else {
+                PolyglotEngineImpl polyglotEngine = ((PolyglotLoggers.LoggerCache) loggerCache).getOwner().getEngine();
+                return polyglotEngine.idToLanguage.containsKey(id) || polyglotEngine.idToInstrument.containsKey(id);
+            }
         }
 
         @Override
-        public Collection<String> getKnownLoggerIds() {
-            List<String> ids = new ArrayList<>();
-            ids.addAll(PolyglotLoggers.getInternalIds());
-            ids.addAll(LanguageCache.languages().keySet());
-            ids.addAll(InstrumentCache.load().keySet());
+        public Collection<String> getKnownLoggerIds(Object loggerCache) {
+            List<String> ids = new ArrayList<>(PolyglotLoggers.getInternalIds());
+            if (loggerCache == PolyglotLoggers.LoggerCache.DEFAULT) {
+                /*
+                 * TruffleLogger#getLogger() is invoked from a static initializer, no vmObject
+                 * anchor is available at this point.
+                 */
+                ids.addAll(LanguageCache.languages().keySet());
+                ids.addAll(InstrumentCache.load().keySet());
+            } else {
+                PolyglotEngineImpl polyglotEngine = ((PolyglotLoggers.LoggerCache) loggerCache).getOwner().getEngine();
+                ids.addAll(polyglotEngine.idToLanguage.keySet());
+                ids.addAll(polyglotEngine.idToInstrument.keySet());
+            }
             Collections.sort(ids);
             return ids;
         }

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotEngineImpl.java

@@ -2447,24 +2447,34 @@ static void logCloseOnCollectedError(PolyglotEngineImpl engine, String reason, T
             case Ignore -> {
             }
             case Print -> {
-                StringWriter message = new StringWriter();
-                try (PrintWriter errWriter = new PrintWriter(message)) {
-                    errWriter.printf("""
-                                    [engine] WARNING: %s
-                                    To customize the behavior of this warning, use 'engine.CloseOnGCFailureAction' option or the 'polyglot.engine.CloseOnGCFailureAction' system property.
-                                    The accepted values are:
-                                      - Ignore:    Do not print this warning.
-                                      - Print:     Print this warning (default value).
-                                      - Throw:     Throw an exception instead of printing this warning.
-                                    """, reason);
-                    exception.printStackTrace(errWriter);
+                if (closeOnCollectedErrorLogged.compareAndSet(false, true)) {
+                    logCloseOnCollectedError(reason, exception);
                 }
-                logFallback(message.toString());
             }
+            case PrintAll -> logCloseOnCollectedError(reason, exception);
             case Throw -> throw new RuntimeException(reason, exception);
         }
     }
 
+    private static final AtomicBoolean closeOnCollectedErrorLogged = new AtomicBoolean();
+
+    private static void logCloseOnCollectedError(String reason, Throwable exception) {
+        StringWriter message = new StringWriter();
+        try (PrintWriter errWriter = new PrintWriter(message)) {
+            errWriter.printf("""
+                            [engine] WARNING: %s
+                            To customize the behavior of this warning, use 'engine.CloseOnGCFailureAction' option or the 'polyglot.engine.CloseOnGCFailureAction' system property.
+                            The accepted values are:
+                              - Ignore:    Do not print this warning.
+                              - Print:     Print this warning only for the first occurrence; suppress subsequent ones (default value).
+                              - PrintAll:  Print this warning.
+                              - Throw:     Throw an exception instead of printing this warning.
+                            """, reason);
+            exception.printStackTrace(errWriter);
+        }
+        logFallback(message.toString());
+    }
+
     static final class StableLocalLocations {
 
         @CompilationFinal(dimensions = 1) final LocalLocation[] locations;

truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/PolyglotEngineOptions.java

@@ -192,12 +192,14 @@ public StaticObjectStorageStrategies apply(String s) {
     enum CloseOnGCExceptionAction {
         Ignore,
         Print,
+        PrintAll,
         Throw;
 
-        private static final String HELP = "Specifies the action to take when closing a garbage collected engine or context fails.%n" +
+        private static final String HELP = "Specifies the action to take when closing a garbage-collected engine or context fails.%n" +
                         "The accepted values are:%n" +
-                        "    Ignore:    Do not print this warning.%n" +
-                        "    Print:     Print this warning (default value).%n" +
-                        "    Throw:     Throw an exception instead of printing this warning.";
+                        "    Ignore:     Ignore the exception that occurs during close.%n" +
+                        "    Print:      Log the failure only for the first occurrence; suppress subsequent ones (default value).%n" +
+                        "    PrintAll:   Log each failure.%n" +
+                        "    Throw:      Throw an exception instead of logging the failure.";
     }
 }