[GR-67854] Limit search distances and use an int[] for ranges

PullRequest: graal/21410

Author: tkrodriguez

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/core/common/util/IntList.java

@@ -44,7 +44,11 @@ public final class IntList {
      * @param initialCapacity
      */
     public IntList(int initialCapacity) {
-        array = new int[initialCapacity];
+        if (initialCapacity == 0) {
+            array = EMPTY_INT_ARRAY;
+        } else {
+            array = new int[initialCapacity];
+        }
     }
 
     /**

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/graph/Graph.java

@@ -63,7 +63,20 @@ public class Graph implements EventCounter {
 
     public static class Options {
         @Option(help = "Verify graphs often during compilation when assertions are turned on", type = OptionType.Debug)//
-        public static final OptionKey<Boolean> VerifyGraalGraphs = new OptionKey<>(true);
+        public static final OptionKey<Boolean> VerifyGraalGraphs = new OptionKey<>(true) {
+            @Override
+            public Boolean getValueOrDefault(UnmodifiableEconomicMap<OptionKey<?>, Object> values) {
+                if (!Assertions.assertionsEnabled()) {
+                    return false;
+                }
+                return super.getValueOrDefault(values);
+            }
+
+            @Override
+            public Boolean getValue(OptionValues values) {
+                return getValueOrDefault(values.getMap());
+            }
+        };
         @Option(help = "Perform expensive verification of graph inputs, usages, successors and predecessors", type = OptionType.Debug)//
         public static final OptionKey<Boolean> VerifyGraalGraphEdges = new OptionKey<>(false);
         @Option(help = "Graal graph compression is performed when percent of live nodes falls below this value", type = OptionType.Debug)//

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/HotSpotReferenceMapBuilder.java

@@ -24,22 +24,21 @@
  */
 package jdk.graal.compiler.hotspot;
 
+import static jdk.graal.compiler.lir.LIRValueUtil.isJavaConstant;
 import static jdk.vm.ci.code.ValueUtil.asRegister;
 import static jdk.vm.ci.code.ValueUtil.asStackSlot;
 import static jdk.vm.ci.code.ValueUtil.isRegister;
-import static jdk.graal.compiler.lir.LIRValueUtil.isJavaConstant;
 
 import java.util.ArrayList;
 
 import jdk.graal.compiler.core.common.LIRKind;
 import jdk.graal.compiler.core.common.PermanentBailoutException;
+import jdk.graal.compiler.debug.Assertions;
 import jdk.graal.compiler.debug.GraalError;
 import jdk.graal.compiler.lir.LIRFrameState;
 import jdk.graal.compiler.lir.LIRValueUtil;
 import jdk.graal.compiler.lir.Variable;
 import jdk.graal.compiler.lir.framemap.ReferenceMapBuilder;
-import jdk.graal.compiler.debug.Assertions;
-
 import jdk.vm.ci.code.Location;
 import jdk.vm.ci.code.ReferenceMap;
 import jdk.vm.ci.code.StackSlot;
@@ -115,6 +114,7 @@ public ReferenceMap finish(LIRFrameState state) {
                 Location base = null;
                 if (kind.isDerivedReference()) {
                     Variable baseVariable = LIRValueUtil.asVariable(kind.getDerivedReferenceBase());
+                    GraalError.guarantee(state.getLiveBasePointers() != null, "no live base pointers for derived reference %s", baseVariable);
                     Value baseValue = state.getLiveBasePointers().get(baseVariable.index);
                     assert baseValue.getPlatformKind().getVectorLength() == 1 &&
                                     ((LIRKind) baseValue.getValueKind()).isReference(0) &&