Make Node constructors and internal methods package-private.

Author: woess

truffle/src/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/DynamicObject.java

@@ -356,12 +356,16 @@ static Lookup internalLookup() {
      * @see #getDoubleOrDefault(DynamicObject, Object, Object)
      * @since 25.1
      */
+    @GeneratePackagePrivate
     @GenerateCached(true)
     @GenerateInline(false)
     @GenerateUncached
     @ImportStatic(DynamicObject.class)
     public abstract static class GetNode extends Node {
 
+        GetNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -599,6 +603,9 @@ static Object doGeneric(DynamicObject receiver, Object key, Object defaultValue)
     @GenerateInline(false)
     public abstract static class PutNode extends Node {
 
+        PutNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -910,6 +917,9 @@ static Location getNewLocation(Shape oldShape, Shape newShape, Object cachedKey,
     @GenerateInline(false)
     public abstract static class CopyPropertiesNode extends Node {
 
+        CopyPropertiesNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -987,6 +997,9 @@ static boolean updateShape(DynamicObject object) {
     @GenerateInline(false)
     public abstract static class ContainsKeyNode extends Node {
 
+        ContainsKeyNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1051,6 +1064,9 @@ static boolean doUncached(DynamicObject receiver, Object key) {
     @GenerateInline(false)
     public abstract static class RemoveKeyNode extends Node {
 
+        RemoveKeyNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1171,6 +1187,9 @@ static RemovePlan makeRemovePlanOrNull(Shape oldShape, Shape newShape, Property
     @GenerateInline(false)
     public abstract static class GetShapeFlagsNode extends Node {
 
+        GetShapeFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1250,6 +1269,9 @@ static int doUncached(DynamicObject receiver) {
     @GenerateInline(false)
     public abstract static class HasShapeFlagsNode extends Node {
 
+        HasShapeFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1327,6 +1349,9 @@ static boolean doUncached(DynamicObject receiver, int flags) {
     @GenerateInline(false)
     public abstract static class SetShapeFlagsNode extends Node {
 
+        SetShapeFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1421,6 +1446,9 @@ static Shape shapeSetFlags(Shape shape, int newFlags) {
     @GenerateInline(false)
     public abstract static class AddShapeFlagsNode extends Node {
 
+        AddShapeFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1522,6 +1550,9 @@ static Shape shapeAddFlags(Shape shape, int newFlags) {
     @GenerateInline(false)
     public abstract static class IsSharedNode extends Node {
 
+        IsSharedNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1574,6 +1605,9 @@ static boolean doUncached(DynamicObject receiver) {
     @GenerateInline(false)
     public abstract static class MarkSharedNode extends Node {
 
+        MarkSharedNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1644,6 +1678,9 @@ static boolean doUncached(DynamicObject receiver,
     @GenerateInline(false)
     public abstract static class GetDynamicTypeNode extends Node {
 
+        GetDynamicTypeNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1697,6 +1734,9 @@ static Object doUncached(DynamicObject receiver) {
     @GenerateInline(false)
     public abstract static class SetDynamicTypeNode extends Node {
 
+        SetDynamicTypeNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1772,6 +1812,9 @@ static boolean doUncached(DynamicObject receiver, Object objectType,
     @GenerateInline(false)
     public abstract static class GetPropertyFlagsNode extends Node {
 
+        GetPropertyFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1843,6 +1886,9 @@ static int doUncached(DynamicObject receiver, Object key, int defaultValue) {
     @GenerateInline(false)
     public abstract static class SetPropertyFlagsNode extends Node {
 
+        SetPropertyFlagsNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -1960,6 +2006,9 @@ static void maybeUpdateShape(DynamicObject store, Shape newShape) {
     @GenerateInline(false)
     public abstract static class UpdateShapeNode extends Node {
 
+        UpdateShapeNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -2024,6 +2073,9 @@ static boolean doInvalid(DynamicObject receiver) {
     @GenerateInline(false)
     public abstract static class ResetShapeNode extends Node {
 
+        ResetShapeNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -2096,6 +2148,9 @@ static Shape verifyResetShape(Shape currentShape, Shape otherShape) {
     @GenerateInline(false)
     public abstract static class GetPropertyNode extends Node {
 
+        GetPropertyNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -2148,6 +2203,9 @@ static Property doUncached(DynamicObject receiver, Object key) {
     @GenerateInline(false)
     public abstract static class GetKeyArrayNode extends Node {
 
+        GetKeyArrayNode() {
+        }
+
         /**
          * @since 25.1
          */
@@ -2253,6 +2311,9 @@ static Object[] getKeyArray(Shape shape) {
     @GenerateInline(false)
     public abstract static class GetPropertyArrayNode extends Node {
 
+        GetPropertyArrayNode() {
+        }
+
         /**
          * @since 25.1
          */

truffle/src/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Shape.java

@@ -62,7 +62,6 @@
 import java.util.function.IntPredicate;
 import java.util.function.Predicate;
 
-import com.oracle.truffle.api.impl.AbstractAssumption;
 import org.graalvm.collections.EconomicMap;
 import org.graalvm.collections.Equivalence;
 import org.graalvm.collections.Pair;
@@ -75,6 +74,7 @@
 import com.oracle.truffle.api.Truffle;
 import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.NonIdempotent;
+import com.oracle.truffle.api.impl.AbstractAssumption;
 
 /**
  * A Shape is an immutable descriptor of the current object "shape" of a DynamicObject, i.e., object
@@ -742,7 +742,7 @@ protected Shape defineProperty(Object key, Object value, int propertyFlags, int
     }
 
     @TruffleBoundary
-    protected Shape defineProperty(Object key, Object value, int propertyFlags, int putFlags, Property existing) {
+    Shape defineProperty(Object key, Object value, int propertyFlags, int putFlags, Property existing) {
         return ObsolescenceStrategy.defineProperty(this, key, value, propertyFlags, existing, putFlags);
     }
 
@@ -940,7 +940,7 @@ protected Shape replaceProperty(Property oldProperty, Property newProperty) {
     }
 
     @TruffleBoundary
-    protected Shape setPropertyFlags(Property oldProperty, int newFlags) {
+    Shape setPropertyFlags(Property oldProperty, int newFlags) {
         if (oldProperty.getFlags() == newFlags) {
             return this;
         }