Skip to content

ODSC-70761 Update telemetry model classifications #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025
Merged

ODSC-70761 Update telemetry model classifications #1178

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3901004
ODSC-70761 Update telemetry model classifications
agrimk May 11, 2025
6f2c10d
Merge branch 'main' into ODSC-70796_thread_pool_for_telemetry
mrDzurb May 13, 2025
ebb1c14
Merge branch 'main' into ODSC-70796_thread_pool_for_telemetry
mrDzurb May 15, 2025
fc757f6
PR review comments
agrimk May 15, 2025
b92d5fc
Merge conflicts
agrimk May 15, 2025
2a5d9a4
Merge branch 'ODSC-70796_thread_pool_for_telemetry' of github.com:ora…
agrimk May 15, 2025
93f539d
removed unused code
agrimk May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ def _create_deployment(
)

# we arbitrarily choose last 8 characters of OCID to identify MD in telemetry
telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)}
telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8), "custom_base_model": True}
Copy link
Member

@mrDzurb mrDzurb May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is always true? Shouldn't we judge based on the model_type value?


# tracks unique deployments that were created in the user compartment
self.telemetry.record_event_async(
Expand Down
Loading