ODSC-70761 Update telemetry model classifications #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrimk
requested review from
VipulMascarenhas,
ahosler,
darenr,
mayoor,
mrDzurb and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
May 12, 2025
|
|
||
| # we arbitrarily choose last 8 characters of OCID to identify MD in telemetry | ||
| telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)} | ||
| telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8), "custom_base_model": True} |
Member
There was a problem hiding this comment.
Why it is always true? Shouldn't we judge based on the model_type value?
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
…cle/accelerated-data-science into ODSC-70796_thread_pool_for_telemetry
|
📌 Cov diff with main: 📌 Overall coverage: |
qiuosier
approved these changes
May 15, 2025
VipulMascarenhas
approved these changes
May 15, 2025
mrDzurb
approved these changes
May 15, 2025
| telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)} | ||
|
|
||
| if Tags.BASE_MODEL_CUSTOM in tags: | ||
| telemetry_kwargs[ "custom_base_model"] = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.oci.oraclecorp.com/browse/ODSC-70761
ADS changes
In deployment.py, when logging telemetry details for the category
"aqua/{model_type}/deployment", add the {"custom_base_model" : true} indicator in the telemetry_kwargs.
This flag is available in the freeform tags of the model that is being deployed. If Tags.BASE_MODEL_CUSTOM is present, then it is a custom base model.