Skip to content

Conversation

@kumar-shivam-ranjan
Copy link
Contributor

@kumar-shivam-ranjan kumar-shivam-ranjan commented Feb 7, 2025

This PR intends to fix a bug in the API that fetches configuration for

  1. Fine-tuning
  2. Deployment
  3. Model tokenizer

Fine-tuning config

Request:
http://localhost:8888/aqua/finetuning/config/ocid1.datasciencemodel.oc1.iad.xxxx

Response: 
{
    "shape": {
        "VM.GPU.A10.1": {
            "batch_size": 1,
            "replica": 1
        }
    },
    "configuration": {
        "micro_batch_size": 1,
        "gradient_accumulation_steps": 1,
        "gradient_checkpointing": true,
        "val_set_size": 0.1,
        "sequence_len": 2048,
        "sample_packing": true,
        "pad_to_sequence_len": true,
        "optimizer": "adamw_torch",
        "lr_scheduler": "cosine",
        "learning_rate": 0.0002,
        "flash_attention": true,
        "bf16": true,
        "fp16": false,
        "tf32": false,
        "logging_steps": 1,
        "adapter": "lora",
        "lora_r": 32,
        "lora_alpha": 16,
        "lora_dropout": 0.05,
        "lora_target_linear": true,
        "lora_target_modules": [
            "q_proj",
            "k_proj"
        ]
    }
}

Hugging model tokenizer

Request:
http://localhost:8888/aqua/model/ocid1.datasciencemodel.oc1.iad.xxxx/tokenizer

Response:
{
    "add_bos_token": true,
    "add_eos_token": false,
    "bos_token": {
        "__type": "AddedToken",
        "content": "<s>",
        "lstrip": false,
        "normalized": true,
        "rstrip": false,
        "single_word": false
    },
    "clean_up_tokenization_spaces": false,
    "eos_token": {
        "__type": "AddedToken",
        "content": "</s>",
        "lstrip": false,
        "normalized": true,
        "rstrip": false,
        "single_word": false
    },
    "legacy": null,
    "model_max_length": 1000000000000000019884624838656,
    "pad_token": null,
    "sp_model_kwargs": {},
    "tokenizer_class": "CodeLlamaTokenizer",
    "unk_token": {
        "__type": "AddedToken",
        "content": "<unk>",
        "lstrip": false,
        "normalized": true,
        "rstrip": false,
        "single_word": false
    }
}

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 7, 2025
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-56.68%

ads/aqua/app.py Outdated
if not is_path_exists(config_path):
config_path = f"{artifact_path.rstrip('/')}/"
config_file_path = f"{config_path}{config_file_name}"
config_file_path = f"{config_path.rstrip('/')}/{config_file_name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use os.path.join here? that should take care of it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.
Thanks

@kumar-shivam-ranjan kumar-shivam-ranjan merged commit 14b4b6c into main Feb 7, 2025
21 checks passed
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-56.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants