Skip to content

Commit f2f6ee2

Browse files
committed
renamed the timestamp column to commit_timestamp
1 parent 66da73d commit f2f6ee2

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

ads/feature_store/dataset.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -838,13 +838,13 @@ def check_resource_materialization(self):
838838
def as_of(
839839
self,
840840
version_number: int = None,
841-
timestamp: datetime = None,
841+
commit_timestamp: datetime = None,
842842
):
843843
"""preview the feature definition and return the response in dataframe.
844844
845845
Parameters
846846
----------
847-
timestamp: datetime
847+
commit_timestamp: datetime
848848
commit date time to preview in format yyyy-MM-dd or yyyy-MM-dd HH:mm:ss
849849
commit date time is maintained for every ingestion commit using delta lake
850850
version_number: int
@@ -858,11 +858,11 @@ def as_of(
858858
"""
859859
self.check_resource_materialization()
860860

861-
validate_delta_format_parameters(timestamp, version_number)
861+
validate_delta_format_parameters(commit_timestamp, version_number)
862862
target_table = self.target_delta_table()
863863

864864
return self.spark_engine.get_time_version_data(
865-
target_table, version_number, timestamp
865+
target_table, version_number, commit_timestamp
866866
)
867867

868868
def profile(self):

ads/feature_store/feature_group.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,13 +1035,13 @@ def preview(
10351035
def as_of(
10361036
self,
10371037
version_number: int = None,
1038-
timestamp: datetime = None,
1038+
commit_timestamp: datetime = None,
10391039
):
10401040
"""preview the feature definition and return the response in dataframe.
10411041
10421042
Parameters
10431043
----------
1044-
timestamp: datetime
1044+
commit_timestamp: datetime
10451045
commit date time to preview in format yyyy-MM-dd or yyyy-MM-dd HH:mm:ss
10461046
commit date time is maintained for every ingestion commit using delta lake
10471047
version_number: int
@@ -1055,11 +1055,11 @@ def as_of(
10551055
"""
10561056
self.check_resource_materialization()
10571057

1058-
# validate_delta_format_parameters(timestamp, version_number)
1058+
validate_delta_format_parameters(commit_timestamp, version_number)
10591059
target_table = self.target_delta_table()
10601060

10611061
return self.spark_engine.get_time_version_data(
1062-
target_table, version_number, timestamp
1062+
target_table, version_number, commit_timestamp
10631063
)
10641064

10651065
def profile(self):

0 commit comments

Comments
 (0)