consolidate helper fn

Author: ahosler

ads/opctl/operator/lowcode/anomaly/model/base_model.py

@@ -245,7 +245,7 @@ def _save_report(
         """Saves resulting reports to the given folder."""
         import datapane as dp
 
-        output_dir = find_output_dirname(self.spec.output_directory)
+        unique_output_dir = find_output_dirname(self.spec.output_directory)
 
         if ObjectStorageDetails.is_oci_path(unique_output_dir):
             storage_options = default_signer()
@@ -286,7 +286,9 @@ def _save_report(
         if test_metrics is not None and not test_metrics.empty:
             write_data(
                 data=test_metrics.rename_axis("metrics").reset_index(),
-                filename=os.path.join(output_dir, self.spec.test_metrics_filename),
+                filename=os.path.join(
+                    unique_output_dir, self.spec.test_metrics_filename
+                ),
                 format="csv",
                 storage_options=storage_options,
             )

ads/opctl/operator/lowcode/common/utils.py

@@ -106,40 +106,6 @@ def write_data(data, filename, format, storage_options, index=False, **kwargs):
     )
 
 
-def get_unique_report_dir(output_dir: str) -> str:
-    """
-    Generate a unique directory path for the report output.
-
-    Parameters
-    ------------
-    output_dir: str
-                The requested output directory path.
-    Returns
-    --------
-    str: The unique directory path for the report output.
-    """
-
-    if output_dir:
-            output_dir = output_dir.url
-            # set the unique directory path as the requested path by the user
-            unique_output_dir = output_dir
-    else:
-        output_dir = "results"
-
-        # If the directory exists, find the next unique directory name by appending an incrementing suffix
-        counter = 1
-        unique_output_dir = f"{output_dir}"
-        while os.path.exists(unique_output_dir):
-            unique_output_dir = f"{output_dir}_{counter}"
-            counter += 1
-        logger.warn(
-            "Since the output directory was not specified, the output will be saved to {} directory.".format(
-                unique_output_dir
-            )
-        )
-    return unique_output_dir
-
-
 def merge_category_columns(data, target_category_columns):
     result = data.apply(
         lambda x: "__".join([str(x[col]) for col in target_category_columns]), axis=1