Skip to content

Commit ee8dbf8

Browse files
update logging for deployment operations
1 parent a8321a1 commit ee8dbf8

File tree

4 files changed

+25
-13
lines changed

4 files changed

+25
-13
lines changed

ads/aqua/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python
2-
# Copyright (c) 2024 Oracle and/or its affiliates.
2+
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
33
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
44

55
import json
@@ -298,7 +298,7 @@ def get_config(self, model_id: str, config_file_name: str) -> Dict:
298298
config = {}
299299
artifact_path = get_artifact_path(oci_model.custom_metadata_list)
300300
if not artifact_path:
301-
logger.error(
301+
logger.debug(
302302
f"Failed to get artifact path from custom metadata for the model: {model_id}"
303303
)
304304
return config

ads/aqua/extension/base_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python
2-
# Copyright (c) 2025 Oracle and/or its affiliates.
2+
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
33
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
44

55

ads/aqua/model/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python
2-
# Copyright (c) 2025 Oracle and/or its affiliates.
2+
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
33
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
44
import os
55
import pathlib

ads/aqua/modeldeployment/deployment.py

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#!/usr/bin/env python
2-
# Copyright (c) 2024 Oracle and/or its affiliates.
2+
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
33
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
44

5-
import logging
65
import shlex
76
from typing import Dict, List, Optional, Union
87

@@ -271,7 +270,7 @@ def create(
271270
f"field. Either re-register the model with custom container URI, or set container_image_uri "
272271
f"parameter when creating this deployment."
273272
) from err
274-
logging.info(
273+
logger.info(
275274
f"Aqua Image used for deploying {aqua_model.id} : {container_image_uri}"
276275
)
277276

@@ -282,14 +281,14 @@ def create(
282281
default_cmd_var = shlex.split(cmd_var_string)
283282
if default_cmd_var:
284283
cmd_var = validate_cmd_var(default_cmd_var, cmd_var)
285-
logging.info(f"CMD used for deploying {aqua_model.id} :{cmd_var}")
284+
logger.info(f"CMD used for deploying {aqua_model.id} :{cmd_var}")
286285
except ValueError:
287-
logging.debug(
286+
logger.debug(
288287
f"CMD will be ignored for this deployment as {AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME} "
289288
f"key is not available in the custom metadata field for this model."
290289
)
291290
except Exception as e:
292-
logging.error(
291+
logger.error(
293292
f"There was an issue processing CMD arguments. Error: {str(e)}"
294293
)
295294

@@ -385,7 +384,7 @@ def create(
385384
if key not in env_var:
386385
env_var.update(env)
387386

388-
logging.info(f"Env vars used for deploying {aqua_model.id} :{env_var}")
387+
logger.info(f"Env vars used for deploying {aqua_model.id} :{env_var}")
389388

390389
# Start model deployment
391390
# configure model deployment infrastructure
@@ -440,10 +439,14 @@ def create(
440439
.with_runtime(container_runtime)
441440
).deploy(wait_for_completion=False)
442441

442+
deployment_id = deployment.dsc_model_deployment.id
443+
logger.info(
444+
f"Aqua model deployment {deployment_id} created for model {aqua_model.id}."
445+
)
443446
model_type = (
444447
AQUA_MODEL_TYPE_CUSTOM if is_fine_tuned_model else AQUA_MODEL_TYPE_SERVICE
445448
)
446-
deployment_id = deployment.dsc_model_deployment.id
449+
447450
# we arbitrarily choose last 8 characters of OCID to identify MD in telemetry
448451
telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)}
449452

@@ -539,25 +542,31 @@ def list(self, **kwargs) -> List["AquaDeployment"]:
539542
value=state,
540543
)
541544

545+
logger.info(
546+
f"Fetched {len(results)} model deployments from compartment_id={compartment_id}."
547+
)
542548
# tracks number of times deployment listing was called
543549
self.telemetry.record_event_async(category="aqua/deployment", action="list")
544550

545551
return results
546552

547553
@telemetry(entry_point="plugin=deployment&action=delete", name="aqua")
548554
def delete(self, model_deployment_id: str):
555+
logger.info(f"Deleting model deployment {model_deployment_id}.")
549556
return self.ds_client.delete_model_deployment(
550557
model_deployment_id=model_deployment_id
551558
).data
552559

553560
@telemetry(entry_point="plugin=deployment&action=deactivate", name="aqua")
554561
def deactivate(self, model_deployment_id: str):
562+
logger.info(f"Deactivating model deployment {model_deployment_id}.")
555563
return self.ds_client.deactivate_model_deployment(
556564
model_deployment_id=model_deployment_id
557565
).data
558566

559567
@telemetry(entry_point="plugin=deployment&action=activate", name="aqua")
560568
def activate(self, model_deployment_id: str):
569+
logger.info(f"Activating model deployment {model_deployment_id}.")
561570
return self.ds_client.activate_model_deployment(
562571
model_deployment_id=model_deployment_id
563572
).data
@@ -579,6 +588,8 @@ def get(self, model_deployment_id: str, **kwargs) -> "AquaDeploymentDetail":
579588
AquaDeploymentDetail:
580589
The instance of the Aqua model deployment details.
581590
"""
591+
logger.info(f"Fetching model deployment details for {model_deployment_id}.")
592+
582593
model_deployment = self.ds_client.get_model_deployment(
583594
model_deployment_id=model_deployment_id, **kwargs
584595
).data
@@ -594,7 +605,8 @@ def get(self, model_deployment_id: str, **kwargs) -> "AquaDeploymentDetail":
594605

595606
if not oci_aqua:
596607
raise AquaRuntimeError(
597-
f"Target deployment {model_deployment_id} is not Aqua deployment."
608+
f"Target deployment {model_deployment_id} is not Aqua deployment as it does not contain "
609+
f"{Tags.AQUA_TAG} tag."
598610
)
599611

600612
log_id = ""

0 commit comments

Comments
 (0)