clean up

Author: VipulMascarenhas

ads/model/generic_model.py

@@ -3024,9 +3024,15 @@ def download_artifact(
             The connection timeout in seconds for the client.
         """
 
+        model_id = ocid.lower()
+        target_dir = (
+            artifact_dir
+            if not ObjectStorageDetails.is_oci_path(artifact_dir)
+            else tempfile.mkdtemp()
+        )
+
         model_deployment = None
 
-        model_id = ocid.lower()
         if DataScienceModelType.MODEL_DEPLOYMENT in ocid:
             model_deployment = ModelDeployment.from_id(ocid)
             model_id = model_deployment.properties.model_id
@@ -3035,12 +3041,6 @@ def download_artifact(
                 f"Invalid OCID: {ocid}. Please provide valid model OCID or model deployment OCID."
             )
 
-        target_dir = (
-            artifact_dir
-            if not ObjectStorageDetails.is_oci_path(artifact_dir)
-            else tempfile.mkdtemp()
-        )
-
         dsc_model = DataScienceModel.from_id(model_id)
 
         if not load_artifact: