Added Failure Indicator & Logging Enhancements (#1086)

Author: prasankh

ads/opctl/operator/common/utils.py

@@ -9,6 +9,7 @@
 import sys
 import time
 import traceback
+import uuid
 from string import Template
 from typing import Any, Dict, List, Tuple
 
@@ -17,6 +18,7 @@
 from cerberus import Validator
 
 from ads.opctl import logger, utils
+from ads.common.oci_logging import OCILog
 
 CONTAINER_NETWORK = "CONTAINER_NETWORK"
 
@@ -190,3 +192,17 @@ def print_traceback():
     if logger.level == logging.DEBUG:
         ex_type, ex, tb = sys.exc_info()
         traceback.print_tb(tb)
+
+
+def create_log_in_log_group(compartment_id, log_group_id, auth, log_name=None):
+    """
+    Creates a log within a given log group
+    """
+    if not log_name:
+        log_name = f"log-{int(time.time())}-{uuid.uuid4()}"
+    log = OCILog(display_name=log_name,
+                 log_group_id=log_group_id,
+                 compartment_id=compartment_id,
+                 **auth).create()
+    logger.info(f"Created log with log OCID {log.id}")
+    return log.id

ads/opctl/operator/lowcode/common/transformations.py

@@ -209,7 +209,7 @@ def _missing_value_imputation_hist(self, df):
 
     def _missing_value_imputation_add(self, df):
         """
-        Function fills missing values in the pandas dataframe using liner interpolation
+        Function fills missing values with zero
 
         Parameters
         ----------
@@ -219,15 +219,7 @@ def _missing_value_imputation_add(self, df):
         -------
             A new Pandas DataFrame without missing values.
         """
-        # find columns that all all NA and replace with 0
-        for col in df.columns:
-            # find next int not in list
-            i = 0
-            vals = df[col].unique()
-            while i in vals:
-                i = i + 1
-            df[col] = df[col].fillna(0)
-        return df
+        return df.fillna(0)
 
     def _outlier_treatment(self, df):
         """

ads/opctl/operator/lowcode/forecast/schema.yaml

@@ -379,7 +379,7 @@ spec:
               required: true
             log_id:
               type: string
-              required: true
+              required: false
             auto_scaling:
               type: dict
               required: false

ads/opctl/operator/lowcode/forecast/whatifserve/deployment_manager.py

@@ -15,6 +15,7 @@
 
 from ads.opctl import logger
 from ads.common.model_export_util import prepare_generic_model
+from ads.opctl.operator.common.utils import create_log_in_log_group
 from ads.opctl.operator.lowcode.common.utils import write_data, write_simple_json
 from ads.opctl.operator.lowcode.common.utils import default_signer
 from ..model.forecast_datasets import AdditionalData
@@ -184,6 +185,10 @@ def create_deployment(self):
 
         log_group = self.spec.what_if_analysis.model_deployment.log_group
         log_id = self.spec.what_if_analysis.model_deployment.log_id
+        if not log_id and not self.test_mode:
+            signer = oci.auth.signers.get_resource_principals_signer()
+            auth = {"signer": signer, "config": {}}
+            log_id = create_log_in_log_group(self.compartment_id, log_group, auth)
 
         logs_configuration_details_object = CategoryLogDetails(
             access=LogDetails(log_group_id=log_group,
@@ -211,8 +216,10 @@ def create_deployment(self):
             logger.info(f"deployment metadata :{model_deployment.data}")
             md = data_science.get_model_deployment(model_deployment_id=model_deployment.data.resources[0].identifier)
             self.deployment_info['model_deployment_ocid'] = md.data.id
+            self.deployment_info['status'] = md.data.lifecycle_state
             endpoint_url = md.data.model_deployment_url
             self.deployment_info['model_deployment_endpoint'] = f"{endpoint_url}/predict"
+            self.deployment_info['log_id'] = log_id
 
     def save_deployment_info(self):
         output_dir = self.spec.output_directory.url