PR review changes

Author: agrimk

ads/aqua/model/model.py

@@ -170,7 +170,7 @@ def create(
             Freeform tags for the model.
         defined_tags : Optional[Dict]
             Defined tags for the model.
-        display_name: ptional[str]
+        display_name: Optional[str]
             The display name of the custom model.
 
         Returns

ads/aqua/modeldeployment/deployment.py

@@ -382,6 +382,7 @@ def _create(
             Tags.AQUA_SERVICE_MODEL_TAG,
             Tags.AQUA_FINE_TUNED_MODEL_TAG,
             Tags.AQUA_TAG,
+            Tags.BASE_MODEL_CUSTOM,
         ]:
             if tag in aqua_model.freeform_tags:
                 tags[tag] = aqua_model.freeform_tags[tag]
@@ -561,8 +562,6 @@ def _create(
             AQUA_MODEL_TYPE_CUSTOM if is_fine_tuned_model else AQUA_MODEL_TYPE_SERVICE
         )
 
-        is_custom_base_model = Tags.BASE_MODEL_CUSTOM in aqua_model.freeform_tags
-
         return self._create_deployment(
             create_deployment_details=create_deployment_details,
             aqua_model_id=aqua_model.id,
@@ -574,7 +573,6 @@ def _create(
             env_var=env_var,
             tags=tags,
             cmd_var=cmd_var,
-            is_custom_base_model=is_custom_base_model,
         )
 
     def _create_multi(
@@ -651,7 +649,6 @@ def _create_multi(
         }
 
         model_name = f"{MODEL_NAME_DELIMITER} ".join(model_name_list)
-        is_custom_base_model = Tags.BASE_MODEL_CUSTOM in aqua_model.freeform_tags
 
         aqua_deployment = self._create_deployment(
             create_deployment_details=create_deployment_details,
@@ -663,7 +660,6 @@ def _create_multi(
             health_check_port=health_check_port,
             env_var=env_var,
             tags=tags,
-            is_custom_base_model=is_custom_base_model,
         )
         aqua_deployment.models = create_deployment_details.models
         return aqua_deployment
@@ -679,7 +675,6 @@ def _create_deployment(
         health_check_port: str,
         env_var: dict,
         tags: dict,
-        is_custom_base_model: bool = False,
         cmd_var: Optional[dict] = None,
     ):
         """Creates data science model deployment.
@@ -705,8 +700,6 @@ def _create_deployment(
             The environment variables input for the deployment.
         tags: dict
             The tags input for the deployment.
-        is_custom_base_model: bool, optional
-            The flag set true for custom model.
         cmd_var: dict, optional
             The cmd arguments input for the deployment.
 
@@ -794,8 +787,8 @@ def _create_deployment(
         # we arbitrarily choose last 8 characters of OCID to identify MD in telemetry
         telemetry_kwargs = {"ocid": get_ocid_substring(deployment_id, key_len=8)}
 
-        if is_custom_base_model:
-            telemetry_kwargs["custom_base_model"] = "True"
+        if Tags.BASE_MODEL_CUSTOM in tags:
+            telemetry_kwargs["custom_base_model"] = True
 
         # tracks unique deployments that were created in the user compartment
         self.telemetry.record_event_async(