resolve pr comments:

codeloop · codeloop · commit bccdd308936f · 2024-01-09T07:43:39.000Z
diff --git a/ads/opctl/operator/lowcode/forecast/model/neuralprophet.py b/ads/opctl/operator/lowcode/forecast/model/neuralprophet.py
@@ -96,7 +96,6 @@ def _train_model(self, i, target, df):
                 confidence_interval_width=self.spec.confidence_interval_width
             )
 
-            # for i, (target, df) in enumerate(full_data_dict.items()):
             le, df_encoded = utils._label_encode_dataframe(
                 df, no_encode={self.spec.datetime_column.name, target}
             )
diff --git a/ads/opctl/operator/lowcode/forecast/model/prophet.py b/ads/opctl/operator/lowcode/forecast/model/prophet.py
@@ -65,7 +65,6 @@ def _train_model(self, i, target, df):
                 confidence_interval_width=self.spec.confidence_interval_width
             )
 
-            # for i, (target, df) in enumerate(full_data_dict.items()):
             le, df_encoded = utils._label_encode_dataframe(
                 df, no_encode={self.spec.datetime_column.name, target}
             )
diff --git a/ads/opctl/operator/lowcode/forecast/operator_config.py b/ads/opctl/operator/lowcode/forecast/operator_config.py
@@ -132,7 +132,7 @@ def __post_init__(self):
             self.local_explanation_filename or "local_explanation.csv"
         )
         self.target_column = self.target_column or "Sales"
-        self.errors_dict_filename = "errors_dict.json"
+        self.errors_dict_filename = "errors.json"
         self.model_kwargs = self.model_kwargs or dict()
 
 

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,6 @@ def _train_model(self, i, target, df):`
`96`	`96`	`confidence_interval_width=self.spec.confidence_interval_width`
`97`	`97`	`)`
`98`	`98`
`99`		`- # for i, (target, df) in enumerate(full_data_dict.items()):`
`100`	`99`	`le, df_encoded = utils._label_encode_dataframe(`
`101`	`100`	`df, no_encode={self.spec.datetime_column.name, target}`
`102`	`101`	`)`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,6 @@ def _train_model(self, i, target, df):`
`65`	`65`	`confidence_interval_width=self.spec.confidence_interval_width`
`66`	`66`	`)`
`67`	`67`
`68`		`- # for i, (target, df) in enumerate(full_data_dict.items()):`
`69`	`68`	`le, df_encoded = utils._label_encode_dataframe(`
`70`	`69`	`df, no_encode={self.spec.datetime_column.name, target}`
`71`	`70`	`)`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ def __post_init__(self):`
`132`	`132`	`self.local_explanation_filename or "local_explanation.csv"`
`133`	`133`	`)`
`134`	`134`	`self.target_column = self.target_column or "Sales"`
`135`		`- self.errors_dict_filename = "errors_dict.json"`
	`135`	`+ self.errors_dict_filename = "errors.json"`
`136`	`136`	`self.model_kwargs = self.model_kwargs or dict()`
`137`	`137`
`138`	`138`