add unit test

Author: guptadivyank

ads/feature_store/dataset.py

@@ -785,7 +785,7 @@ def _update_from_oci_dataset_model(self, oci_dataset: OCIDataset) -> "Dataset":
         for infra_attr, dsc_attr in self.attribute_map.items():
             if infra_attr in dataset_details:
                 if infra_attr == self.CONST_OUTPUT_FEATURE_DETAILS:
-                    # May not need if we fix the backend and add feature_group_id to the output_feature
+                    # May not need if we fix the backend and add dataset_id to the output_feature
                     features_list = []
                     for output_feature in dataset_details[infra_attr]["items"]:
                         output_feature["datasetId"] = dataset_details[self.CONST_ID]

tests/unitary/with_extras/feature_store/test_feature_group.py

@@ -20,6 +20,7 @@
 from ads.feature_store.feature_store import FeatureStore
 from ads.feature_store.input_feature_detail import FeatureDetail, FeatureType
 from ads.feature_store.service.oci_feature_group import OCIFeatureGroup
+from ads.feature_store.service.oci_feature_group_job import OCIFeatureGroupJob
 from ads.feature_store.service.oci_feature_store import OCIFeatureStore
 from tests.unitary.with_extras.feature_store.test_feature_group_job import (
     FEATURE_GROUP_JOB_PAYLOAD,
@@ -44,6 +45,14 @@
     "isInferSchema": False,
 }
 
+FEATURE_GROUP_JOB_RESPONSE_PAYLOAD = {
+    "compartmentId": "ocid1.compartment.oc1.iad.xxx",
+    "featureGroupId": "861AA4E9C8E811A79D74C464A01CDF42",
+    "id": "d40265b7-d66e-49a3-ae26-699012e0df5d",
+    "ingestionMode": "OVERWRITE",
+    "lifecycleState": "SUCCEEDED",
+}
+
 
 @pytest.fixture(autouse=True)
 def dataframe_fixture_basic():
@@ -211,14 +220,14 @@ def test_from_id(self, mock_oci_from_id, mock__update_from_oci_fs_model):
 
     @patch.object(OCIFeatureGroup, "create")
     def test_create_success(
-            self,
-            mock_oci_dsc_model_create,
+        self,
+        mock_oci_dsc_model_create,
     ):
         """Tests creating datascience feature_group."""
         oci_dsc_model = OCIFeatureGroup(**FEATURE_GROUP_PAYLOAD)
         mock_oci_dsc_model_create.return_value = oci_dsc_model
 
-        # to check rundom display name
+        # to check random display name
         self.mock_dsc_feature_group.with_name("")
         result = self.mock_dsc_feature_group.create()
         mock_oci_dsc_model_create.assert_called()
@@ -281,7 +290,7 @@ def test__to_oci_fs_entity(self, mock_load_key_file, mock_config_from_file):
     @patch.object(SparkSessionSingleton, "__init__", return_value=None)
     @patch.object(SparkSessionSingleton, "get_spark_session")
     def test_materialise(
-            self, spark_session, get_spark_session, mocke_update, dataframe_fixture_basic
+        self, spark_session, get_spark_session, mocke_update, dataframe_fixture_basic
     ):
         with patch.object(FeatureGroupJob, "create") as mock_feature_group_job:
             with patch.object(FeatureStore, "from_id"):
@@ -324,10 +333,20 @@ def test_history(self, feature_store, spark_session, get_spark_session):
     @patch.object(SparkSessionSingleton, "get_spark_session")
     @patch.object(OCIFeatureStore, "from_id")
     def test_restore(
-            self, feature_store, spark_session, get_spark_session, mock_update
+        self, feature_store, spark_session, get_spark_session, mock_update
     ):
         with patch.object(SparkEngine, "sql") as mock_execution_strategy:
             mock_execution_strategy.return_value = None
             self.mock_dsc_feature_group.with_id(FEATURE_GROUP_OCID)
             self.mock_dsc_feature_group.restore(1)
             mock_execution_strategy.assert_called_once()
+
+    def test_get_last_job(self):
+        """Tests getting most recent feature group job for a feature group."""
+        with patch.object(FeatureGroupJob, "list") as mock_feature_group_job:
+            self.mock_dsc_feature_group.with_id(FEATURE_GROUP_OCID)
+            mock_feature_group_job.return_value = [
+                FeatureGroupJob.from_dict({"spec": FEATURE_GROUP_JOB_RESPONSE_PAYLOAD})
+            ]
+            fg_job = self.mock_dsc_feature_group.get_last_job()
+            assert fg_job is not None